From: balbi@ti•com (Felipe Balbi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode
Date: Tue, 4 Aug 2015 17:57:22 -0500 [thread overview]
Message-ID: <20150804225722.GA6802@saruman.tx.rr.com> (raw)
In-Reply-To: <55C1370E.1000805@redhat.com>
Hi,
On Wed, Aug 05, 2015 at 12:05:02AM +0200, Hans de Goede wrote:
> Hi,
>
> On 08/04/2015 11:35 PM, Felipe Balbi wrote:
> >On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote:
> >>For some unclear reason sometimes we get VBus errors in host-only mode,
> >>even though we do not have any vbus-detection then. Ignore these.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede@redhat•com>
> >>---
> >> drivers/usb/musb/sunxi.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >>diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> >>index f9f6304..34ce5df 100644
> >>--- a/drivers/usb/musb/sunxi.c
> >>+++ b/drivers/usb/musb/sunxi.c
> >>@@ -194,6 +194,10 @@ static irqreturn_t sunxi_musb_interrupt(int irq, void *__hci)
> >> musb_writeb(musb->mregs, MUSB_FADDR, 0);
> >> }
> >>
> >>+ /* Ignore Vbus errors when in host only mode */
> >>+ if (musb->port_mode == MUSB_PORT_MODE_HOST)
> >>+ musb->int_usb &= ~MUSB_INTR_VBUSERROR;
> >
> >check with a scope if VBUS is really dropping. Host does VBUS detection
> >indeed, at a minimum, for overcurrent protection. You might have
> >something causing VBUS to drop and that something needs to be found,
> >rather than masked.
>
> The boards in question do not have any vbus detection, the usb-phy on
> allwinner boards do not have a vbus sense pin, instead a gpio is used
> in designs which use otg. Designs which use host-only mode typically
> do not have any form of vbus detection at all. In this case we always
> report vbus as being valid to the musb core, so I've no idea why
> the musb core is still generating vbus errors.
PHY must tell MUSB about VBUS level using either ULPI or UTMI+. I'd
check to see if the PHY is at fault, at least.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150804/573864e2/attachment.sig>
next prev parent reply other threads:[~2015-08-04 22:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 21:25 [PATCH] musb: sunxi: Ignore VBus errors in host-only mode Hans de Goede
2015-08-04 21:35 ` Felipe Balbi
2015-08-04 22:05 ` Hans de Goede
2015-08-04 22:57 ` Felipe Balbi [this message]
2015-08-05 13:30 ` Hans de Goede
2015-08-06 8:22 ` [linux-sunxi] " Olliver Schinagl
2015-08-06 14:35 ` Hans de Goede
2015-08-07 8:45 ` Olliver Schinagl
2015-09-04 6:43 ` Olliver Schinagl
2015-09-10 18:23 ` Hans de Goede
2015-09-10 18:30 ` Maxime Ripard
2015-09-10 18:38 ` Hans de Goede
2015-09-14 14:44 ` Bin Liu
2015-09-14 14:59 ` Hans de Goede
2015-09-14 16:58 ` Bin Liu
2015-09-14 17:08 ` Hans de Goede
2015-09-14 17:14 ` Bin Liu
2015-09-14 17:25 ` Hans de Goede
2015-09-14 17:53 ` Bin Liu
2015-09-14 17:56 ` Hans de Goede
2015-09-14 19:06 ` Bin Liu
2015-09-14 20:25 ` Maxime Ripard
2015-09-15 2:54 ` Hans de Goede
2015-09-15 4:20 ` Bin Liu
2016-05-04 10:25 ` Michal Suchanek
[not found] ` <706aa130-3ace-4059-a7c9-44147cd56c28@googlegroups.com>
[not found] ` <af013a0a-9257-4936-9e66-cb38f2e46369@googlegroups.com>
[not found] ` <0106707e-21f3-4aec-92ca-8b951af8a34e@googlegroups.com>
2017-05-12 9:16 ` Maxime Ripard
2015-09-26 12:50 ` Olliver Schinagl
[not found] ` <jwvmvw7zzg5.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-09-28 7:04 ` [linux-sunxi] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804225722.GA6802@saruman.tx.rr.com \
--to=balbi@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox