From: oliver+list@schinagl•nl (Olliver Schinagl)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode
Date: Sat, 26 Sep 2015 14:50:18 +0200 [thread overview]
Message-ID: <5606948A.5040200@schinagl.nl> (raw)
In-Reply-To: <55F1CA9B.3070204@redhat.com>
Hey Hans,
On 10-09-15 20:23, Hans de Goede wrote:
> Hi,
>
> On 04-09-15 08:43, Olliver Schinagl wrote:
>> Hey Hans,
>>
>> On 07-08-15 10:45, Olliver Schinagl wrote:
>>> <snip>
>>>> If you change the dr_mode to host then you _must_ also remove any
>>>> id_det and vbus_det
>>>> gpio settings from the usb_phy node in the dts, as the sun4i phy
>>>> code detects
>>>> host vs otg mode by checking for the presence of these.
>>> Yes, this fixes it and makes it work. Thanks.
>>>
>> I've been going back to this and am wondering if this is something I
>> can look into to fix properly? E.g. if the dts sets dr_mode = host,
>> can we simply ignore the pins and treat them as unset?
>
> AFAIK you cannot unset something in dts. The only solution I
> can comeup with is to add a dr_mode argument to the phy like
> we already have for the otg controller itself.
Actually, it seems that you can :)
&usbphy {
/* Unset otg detect pins as we force dr_mode */
/delete-property/ usb0_id_det-gpio;
/delete-property/ usb0_vbus_det-gpio;
};
is what i am using at the moment.
>
> This is something which we likely need to do anyways to add
> support for peripheral only mode, which we seem to need for
> some "hdmi sticks".
>
> Patches doing this are welcome from my pov.
While my plate is uite fullish too, i may look into it :)
>
> Regards,
>
> Hans
>
next prev parent reply other threads:[~2015-09-26 12:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 21:25 [PATCH] musb: sunxi: Ignore VBus errors in host-only mode Hans de Goede
2015-08-04 21:35 ` Felipe Balbi
2015-08-04 22:05 ` Hans de Goede
2015-08-04 22:57 ` Felipe Balbi
2015-08-05 13:30 ` Hans de Goede
2015-08-06 8:22 ` [linux-sunxi] " Olliver Schinagl
2015-08-06 14:35 ` Hans de Goede
2015-08-07 8:45 ` Olliver Schinagl
2015-09-04 6:43 ` Olliver Schinagl
2015-09-10 18:23 ` Hans de Goede
2015-09-10 18:30 ` Maxime Ripard
2015-09-10 18:38 ` Hans de Goede
2015-09-14 14:44 ` Bin Liu
2015-09-14 14:59 ` Hans de Goede
2015-09-14 16:58 ` Bin Liu
2015-09-14 17:08 ` Hans de Goede
2015-09-14 17:14 ` Bin Liu
2015-09-14 17:25 ` Hans de Goede
2015-09-14 17:53 ` Bin Liu
2015-09-14 17:56 ` Hans de Goede
2015-09-14 19:06 ` Bin Liu
2015-09-14 20:25 ` Maxime Ripard
2015-09-15 2:54 ` Hans de Goede
2015-09-15 4:20 ` Bin Liu
2016-05-04 10:25 ` Michal Suchanek
[not found] ` <706aa130-3ace-4059-a7c9-44147cd56c28@googlegroups.com>
[not found] ` <af013a0a-9257-4936-9e66-cb38f2e46369@googlegroups.com>
[not found] ` <0106707e-21f3-4aec-92ca-8b951af8a34e@googlegroups.com>
2017-05-12 9:16 ` Maxime Ripard
2015-09-26 12:50 ` Olliver Schinagl [this message]
[not found] ` <jwvmvw7zzg5.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-09-28 7:04 ` [linux-sunxi] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5606948A.5040200@schinagl.nl \
--to=oliver+list@schinagl$(echo .)nl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox