From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Sun, 27 Sep 2015 18:53:03 +0200 [thread overview]
Message-ID: <20150927165303.GI31209@lunn.ch> (raw)
In-Reply-To: <560813CF.4000807@schinagl.nl>
On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote:
> Hey Hans,
>
> On 27-09-15 16:57, Hans de Goede wrote:
> >According to the datasheets to n factor for dividing the tclk is
> >2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is
> >on other mv64xxx implementations.
> Ah!
Just to be sure, i checked Kirkwood, Armada XP and Armada 370
datasheets. They all say n+1.
> >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
> >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
Rather than have to extend this list every so often, how about adding
a helper of_device_is_compatible_vendor(), so you can just have:
> >+ if (of_device_is_compatible_vendor(np, "allwinner")
Andrew
next prev parent reply other threads:[~2015-09-27 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 14:57 [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs Hans de Goede
2015-09-27 16:05 ` [linux-sunxi] " Olliver Schinagl
2015-09-27 16:53 ` Andrew Lunn [this message]
2015-09-29 10:14 ` Hans de Goede
2015-09-29 12:29 ` Maxime Ripard
2015-09-29 12:09 ` Maxime Ripard
2015-10-01 18:51 ` Olliver Schinagl
2015-10-20 15:58 ` Wolfram Sang
2015-10-20 22:05 ` Olliver Schinagl
2015-10-25 17:32 ` Olliver Schinagl
2015-09-27 19:36 ` Peter Korsgaard
2015-09-29 12:09 ` Maxime Ripard
2015-11-30 13:51 ` Wolfram Sang
2015-11-30 14:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927165303.GI31209@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox