From: oliver+list@schinagl•nl (Olliver Schinagl)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs
Date: Thu, 01 Oct 2015 20:51:59 +0200 [thread overview]
Message-ID: <560D80CF.6050500@schinagl.nl> (raw)
In-Reply-To: <20150929120943.GP7104@lukather>
Hey Maxime,
On 29-09-15 14:09, Maxime Ripard wrote:
> On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote:
>> Hey Hans,
>>
>> On 27-09-15 16:57, Hans de Goede wrote:
>>> According to the datasheets to n factor for dividing the tclk is
>>> 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is
>>> on other mv64xxx implementations.
>> Ah!
>>> I've contacted Allwinner about this and they have confirmed that the
>>> datasheet is correct.
>>>
>>> This commit fixes the clk-divider calculations for Allwinner SoCs
>>> accordingly.
>> So this explains why all my i2c frequenties are double of what I setup.
>> Thanks for taking the time of figuring it out! I'll give it a test hopefully
>> soon.
> It would have been great to let us know...
If your talking about past tence, I actually did ;) [0][1] and I
actually had a tree made ready just 3 weeks ago with 3.15 to start my
bisection with. It seemed logical to see if it worked there as that was
the first iteration (based on the sunxi/allwinner based tree before the
mv migration.
Anyway, I even built tried to build the kernel! but my gcc failed to
build it so i put it on the back-burner for a while.
WIth Hans having figured it out and fixing it, I'll absolutly will take
a nother look and check with a scope if it all works out now.
Olliver
[0] http://irclog.whitequark.org/linux-sunxi/2015-01-16#11522114;
[1] http://s24.postimg.org/yiykh6kkl/DS1_Z_Quick_Print2.png
> Maxime
>
next prev parent reply other threads:[~2015-10-01 18:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 14:57 [PATCH] i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs Hans de Goede
2015-09-27 16:05 ` [linux-sunxi] " Olliver Schinagl
2015-09-27 16:53 ` Andrew Lunn
2015-09-29 10:14 ` Hans de Goede
2015-09-29 12:29 ` Maxime Ripard
2015-09-29 12:09 ` Maxime Ripard
2015-10-01 18:51 ` Olliver Schinagl [this message]
2015-10-20 15:58 ` Wolfram Sang
2015-10-20 22:05 ` Olliver Schinagl
2015-10-25 17:32 ` Olliver Schinagl
2015-09-27 19:36 ` Peter Korsgaard
2015-09-29 12:09 ` Maxime Ripard
2015-11-30 13:51 ` Wolfram Sang
2015-11-30 14:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D80CF.6050500@schinagl.nl \
--to=oliver+list@schinagl$(echo .)nl \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox