* [PATCH] clocksource: select CLKSRC_MMIO where needed
@ 2016-01-25 16:02 Arnd Bergmann
2016-01-25 19:09 ` Baruch Siach
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:02 UTC (permalink / raw)
To: linux-arm-kernel
The Tegra clocksource implementation uses the clocksource_mmio helper
functions, but currently can be configured without them, which fails:
drivers/clocksource/built-in.o: In function `tegra20_init_timer':
:(.init.text+0xac): undefined reference to `clocksource_mmio_init'
:(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up'
The same problem exists for Digicolor:
drivers/clocksource/built-in.o: In function `digicolor_timer_init':
:(.init.text+0xfa): undefined reference to `clocksource_mmio_init'
:(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down'
I've inspected the Kconfig file to look for other cases that I have not
yet run into, and added an explicit 'select' to each one to ensure we
can successfully link the drivers.
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
drivers/clocksource/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 56777f04d2d9..f70b4f3b4857 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -30,6 +30,7 @@ config CLKSRC_MMIO
config DIGICOLOR_TIMER
bool "Digicolor timer driver" if COMPILE_TEST
depends on GENERIC_CLOCKEVENTS
+ select CLKSRC_MMIO
help
Enables the support for the digicolor timer driver.
@@ -55,6 +56,7 @@ config ARMADA_370_XP_TIMER
bool "Armada 370 and XP timer driver" if COMPILE_TEST
depends on ARM
select CLKSRC_OF
+ select CLKSRC_MMIO
help
Enables the support for the Armada 370 and XP timer driver.
@@ -89,6 +91,7 @@ config SUN5I_HSTIMER
config TEGRA_TIMER
bool "Tegra timer driver" if COMPILE_TEST
+ select CLKSRC_MMIO
depends on ARM
help
Enables support for the Tegra driver.
@@ -263,6 +266,7 @@ config FSL_FTM_TIMER
config VF_PIT_TIMER
bool
+ select CLKSRC_MMIO
help
Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
@@ -394,6 +398,7 @@ config CLKSRC_ST_LPC
bool "Low power clocksource found in the LPC" if COMPILE_TEST
select CLKSRC_OF if OF
depends on HAS_IOMEM
+ select CLKSRC_MMIO
help
Enable this option to use the Low Power controller timer
as clocksource.
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] clocksource: select CLKSRC_MMIO where needed
2016-01-25 16:02 [PATCH] clocksource: select CLKSRC_MMIO where needed Arnd Bergmann
@ 2016-01-25 19:09 ` Baruch Siach
0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2016-01-25 19:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote:
> The Tegra clocksource implementation uses the clocksource_mmio helper
> functions, but currently can be configured without them, which fails:
>
> drivers/clocksource/built-in.o: In function `tegra20_init_timer':
> :(.init.text+0xac): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up'
>
> The same problem exists for Digicolor:
>
> drivers/clocksource/built-in.o: In function `digicolor_timer_init':
> :(.init.text+0xfa): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down'
>
> I've inspected the Kconfig file to look for other cases that I have not
> yet run into, and added an explicit 'select' to each one to ensure we
> can successfully link the drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
For Digicolor:
Acked-by: Baruch Siach <baruch@tkos•co.il>
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-25 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 16:02 [PATCH] clocksource: select CLKSRC_MMIO where needed Arnd Bergmann
2016-01-25 19:09 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox