From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] irqchip: irq-armada-370-xp: use the generic MSI infrastructure
Date: Tue, 26 Jan 2016 16:41:28 +0100 [thread overview]
Message-ID: <20160126164128.68d007f8@free-electrons.com> (raw)
In-Reply-To: <87si2te6pk.fsf@free-electrons.com>
Gregory,
On Wed, 23 Dec 2015 12:37:43 +0100, Gregory CLEMENT wrote:
> > - mutex_unlock(&msi_used_lock);
> > + msg->address_lo = lower_32_bits(msi_doorbell_addr);
> > + msg->address_hi = upper_32_bits(msi_doorbell_addr);
> > + msg->data = 0xf00 | (data->hwirq + PCI_MSI_DOORBELL_START);
>
> So here instead of using the 16 value you use PCI_MSI_DOORBELL_START
> which seems better. What about using it also in
> armada_370_xp_handle_msi_irq?
Good idea, I've fixed this. Since it's not related to the conversion to
the generic MSI infrastructure, I made this change as part of a
separate commit (this one is already quite difficult to read as a
patch, as you noted).
Thanks for the feedback!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-26 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 14:19 [PATCH 0/4] Use new MSI infrastructure on Marvell EBU Thomas Petazzoni
2015-12-21 14:19 ` [PATCH 1/4] irqchip: irq-armada-370-xp: add Kconfig option for the driver Thomas Petazzoni
2015-12-23 11:11 ` Gregory CLEMENT
2015-12-21 14:19 ` [PATCH 2/4] irqchip: irq-armada-370-xp: use the generic MSI infrastructure Thomas Petazzoni
2015-12-23 11:37 ` Gregory CLEMENT
2016-01-26 15:41 ` Thomas Petazzoni [this message]
2016-01-26 14:12 ` Marc Zyngier
2016-01-26 15:52 ` Thomas Petazzoni
2016-01-26 16:33 ` Marc Zyngier
2015-12-21 14:19 ` [PATCH 3/4] irqchip: irq-armada-370-xp: use shorter names for irq_chip Thomas Petazzoni
2015-12-23 11:23 ` Gregory CLEMENT
2016-01-26 16:07 ` Thomas Petazzoni
2016-01-26 16:23 ` Gregory CLEMENT
2015-12-21 14:19 ` [PATCH 4/4] ARM: mvebu: use the ARMADA_370_XP_IRQ option Thomas Petazzoni
2015-12-23 11:24 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126164128.68d007f8@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox