* [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0
@ 2016-03-02 22:57 Wolfram Sang
2016-03-02 23:28 ` Joachim Eastwood
2016-03-04 15:01 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-03-02 22:57 UTC (permalink / raw)
To: linux-arm-kernel
From: Wolfram Sang <wsa+renesas@sang-engineering•com>
The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering•com>
---
drivers/pwm/pwm-lpc18xx-sct.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
index 9163085101bc94..9861fed4e67d04 100644
--- a/drivers/pwm/pwm-lpc18xx-sct.c
+++ b/drivers/pwm/pwm-lpc18xx-sct.c
@@ -360,6 +360,11 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev)
}
lpc18xx_pwm->clk_rate = clk_get_rate(lpc18xx_pwm->pwm_clk);
+ if (!lpc18xx_pwm->clk_rate) {
+ dev_err(&pdev->dev, "pwm clock has no frequency\n");
+ ret = -EINVAL;
+ goto disable_pwmclk;
+ }
mutex_init(&lpc18xx_pwm->res_lock);
mutex_init(&lpc18xx_pwm->period_lock);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0
2016-03-02 22:57 [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0 Wolfram Sang
@ 2016-03-02 23:28 ` Joachim Eastwood
2016-03-04 15:01 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Joachim Eastwood @ 2016-03-02 23:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Wolfram,
On 2 March 2016 at 23:57, Wolfram Sang <wsa@the-dreams•de> wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering•com>
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering•com>
> ---
> drivers/pwm/pwm-lpc18xx-sct.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
> index 9163085101bc94..9861fed4e67d04 100644
> --- a/drivers/pwm/pwm-lpc18xx-sct.c
> +++ b/drivers/pwm/pwm-lpc18xx-sct.c
> @@ -360,6 +360,11 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev)
> }
>
> lpc18xx_pwm->clk_rate = clk_get_rate(lpc18xx_pwm->pwm_clk);
> + if (!lpc18xx_pwm->clk_rate) {
> + dev_err(&pdev->dev, "pwm clock has no frequency\n");
> + ret = -EINVAL;
> + goto disable_pwmclk;
> + }
Acked-by: Joachim Eastwood <manabian@gmail•com>
Thanks for fixing this.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0
2016-03-02 22:57 [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0 Wolfram Sang
2016-03-02 23:28 ` Joachim Eastwood
@ 2016-03-04 15:01 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-03-04 15:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 02, 2016 at 11:57:09PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering•com>
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering•com>
> ---
> drivers/pwm/pwm-lpc18xx-sct.c | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160304/f6a9192e/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-04 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 22:57 [PATCH v2] pwm: pwm-lpc18xx-sct: test clock rate to avoid division by 0 Wolfram Sang
2016-03-02 23:28 ` Joachim Eastwood
2016-03-04 15:01 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox