From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular
Date: Tue, 29 Mar 2016 12:45:25 +0100 [thread overview]
Message-ID: <20160329114525.GC6745@arm.com> (raw)
In-Reply-To: <1459113058-14340-5-git-send-email-paul.gortmaker@windriver.com>
On Sun, Mar 27, 2016 at 05:10:58PM -0400, Paul Gortmaker wrote:
> The Kconfig for this driver is currently:
>
> config ARM_CCN
> bool "ARM CCN driver support"
>
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We exchange module.h for moduleparam.h here since the driver uses
> module_param_named, and for now the easiest way to remain compatible
> with existing bootargs use cases is to leave this as-is.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
I'd much rather fix the driver to build as a module, if at all possible.
Suzuki (CC'd) is taking a look at that, so please drop this patch for
now.
Will
next prev parent reply other threads:[~2016-03-29 11:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:10 [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Paul Gortmaker
2016-03-27 21:10 ` [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular Paul Gortmaker
2016-04-07 1:26 ` Brian Norris
2016-04-12 18:48 ` Florian Fainelli
2016-03-27 21:10 ` [PATCH 2/4] drivers/bus: make imx-weim.c " Paul Gortmaker
2016-04-07 2:58 ` Shawn Guo
2016-03-27 21:10 ` [PATCH 3/4] drivers/bus: make simple-pm-bus.c " Paul Gortmaker
2016-03-28 8:28 ` Geert Uytterhoeven
2016-03-28 14:35 ` Paul Gortmaker
2016-03-27 21:10 ` [PATCH 4/4] drivers/bus: make arm-ccn.c driver " Paul Gortmaker
2016-03-29 11:45 ` Will Deacon [this message]
2016-03-29 11:53 ` Pawel Moll
2016-03-29 12:30 ` Will Deacon
2016-03-29 13:11 ` Pawel Moll
2016-03-29 13:14 ` Paul Gortmaker
2016-03-29 11:38 ` [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329114525.GC6745@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox