From: f.fainelli@gmail•com (Florian Fainelli)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular
Date: Tue, 12 Apr 2016 11:48:21 -0700 [thread overview]
Message-ID: <570D42F5.6070308@gmail.com> (raw)
In-Reply-To: <20160407012639.GA30748@localhost>
On 06/04/16 18:26, Brian Norris wrote:
> On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote:
>> The Kconfig for this driver is currently:
>>
>> config BRCMSTB_GISB_ARB
>> bool "Broadcom STB GISB bus arbiter"
>>
>> ...meaning that it currently is not being built as a module by anyone.
>> Lets remove all modular references, so that when reading the driver
>> there is no doubt it is builtin-only.
>>
>> Since module_init translates to device_initcall in the non-modular
>> case, the init ordering remains unchanged with this commit.
>>
>> Cc: Brian Norris <computersforpeace@gmail•com>
>> Cc: Gregory Fong <gregory.0xf0@gmail•com>
>> Cc: Florian Fainelli <f.fainelli@gmail•com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
>
> I think this driver probably doesn't make too much sense as a module
> anyway (among other things, we can't hook the ARM fault handler beyond
> init time, as it's marked __init). So:
>
> Acked-by: Brian Norris <computersforpeace@gmail•com>
>
> Might be good to get Florian's ack though, as I'm not using this
> platform any more.
I concur with Brian here, your changes look good:
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
Thanks Paul
--
Florian
next prev parent reply other threads:[~2016-04-12 18:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:10 [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Paul Gortmaker
2016-03-27 21:10 ` [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular Paul Gortmaker
2016-04-07 1:26 ` Brian Norris
2016-04-12 18:48 ` Florian Fainelli [this message]
2016-03-27 21:10 ` [PATCH 2/4] drivers/bus: make imx-weim.c " Paul Gortmaker
2016-04-07 2:58 ` Shawn Guo
2016-03-27 21:10 ` [PATCH 3/4] drivers/bus: make simple-pm-bus.c " Paul Gortmaker
2016-03-28 8:28 ` Geert Uytterhoeven
2016-03-28 14:35 ` Paul Gortmaker
2016-03-27 21:10 ` [PATCH 4/4] drivers/bus: make arm-ccn.c driver " Paul Gortmaker
2016-03-29 11:45 ` Will Deacon
2016-03-29 11:53 ` Pawel Moll
2016-03-29 12:30 ` Will Deacon
2016-03-29 13:11 ` Pawel Moll
2016-03-29 13:14 ` Paul Gortmaker
2016-03-29 11:38 ` [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D42F5.6070308@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox