public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
@ 2016-09-18 14:13 Paul Kocialkowski
  2016-09-20 12:24 ` Jon Hunter
  2016-11-07 13:29 ` Thierry Reding
  0 siblings, 2 replies; 7+ messages in thread
From: Paul Kocialkowski @ 2016-09-18 14:13 UTC (permalink / raw)
  To: linux-arm-kernel

This enables the GPU node for tegra124 nyan boards, which is required to
get graphics acceleration with nouveau on these devices.

Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index dab9509..225ca77 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -42,6 +42,12 @@
 		};
 	};
 
+	gpu at 0,57000000 {
+		status = "okay";
+
+		vdd-supply = <&vdd_gpu>;
+	};
+
 	serial at 70006000 {
 		/* Debug connector on the bottom of the board near SD card. */
 		status = "okay";
@@ -214,7 +220,7 @@
 					regulator-always-on;
 				};
 
-				sd6 {
+				vdd_gpu: sd6 {
 					regulator-name = "+VDD_GPU_AP";
 					regulator-min-microvolt = <650000>;
 					regulator-max-microvolt = <1200000>;
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-09-18 14:13 [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski
@ 2016-09-20 12:24 ` Jon Hunter
  2016-09-20 18:17   ` Paul Kocialkowski
  2016-11-07 13:29 ` Thierry Reding
  1 sibling, 1 reply; 7+ messages in thread
From: Jon Hunter @ 2016-09-20 12:24 UTC (permalink / raw)
  To: linux-arm-kernel


On 18/09/16 15:13, Paul Kocialkowski wrote:
> This enables the GPU node for tegra124 nyan boards, which is required to
> get graphics acceleration with nouveau on these devices.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
> index dab9509..225ca77 100644
> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
> @@ -42,6 +42,12 @@
>  		};
>  	};
>  
> +	gpu at 0,57000000 {
> +		status = "okay";
> +
> +		vdd-supply = <&vdd_gpu>;
> +	};
> +
>  	serial at 70006000 {
>  		/* Debug connector on the bottom of the board near SD card. */
>  		status = "okay";
> @@ -214,7 +220,7 @@
>  					regulator-always-on;
>  				};
>  
> -				sd6 {
> +				vdd_gpu: sd6 {
>  					regulator-name = "+VDD_GPU_AP";
>  					regulator-min-microvolt = <650000>;
>  					regulator-max-microvolt = <1200000>;
> 

Looks good to me. I see the following error when booting but looking at the
code appears to be benign. Thierry, Alex, is this normal/okay?

[    5.715181] nouveau 57000000.gpu: NVIDIA GK20A (0ea000a1)                                                                                            
[    5.720625] nouveau 57000000.gpu: imem: using IOMMU                                                                                                  
[    5.803694] nouveau 57000000.gpu: DRM: VRAM: 0 MiB                                                                                                   
[    5.808501] nouveau 57000000.gpu: DRM: GART: 1048576 MiB                                                                                             
[    5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel, -22                                                                              
[    5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies  

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-09-20 12:24 ` Jon Hunter
@ 2016-09-20 18:17   ` Paul Kocialkowski
  2016-09-21  7:57     ` Jon Hunter
  0 siblings, 1 reply; 7+ messages in thread
From: Paul Kocialkowski @ 2016-09-20 18:17 UTC (permalink / raw)
  To: linux-arm-kernel

Le mardi 20 septembre 2016 ? 13:24 +0100, Jon Hunter a ?crit?:
> On 18/09/16 15:13, Paul Kocialkowski wrote:
> > 
> > This enables the GPU node for tegra124 nyan boards, which is required to
> > get graphics acceleration with nouveau on these devices.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
> > ---
> > ?arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
> > ?1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
> > b/arch/arm/boot/dts/tegra124-nyan.dtsi
> > index dab9509..225ca77 100644
> > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
> > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
> > @@ -42,6 +42,12 @@
> > ?		};
> > ?	};
> > ?
> > +	gpu at 0,57000000 {
> > +		status = "okay";
> > +
> > +		vdd-supply = <&vdd_gpu>;
> > +	};
> > +
> > ?	serial at 70006000 {
> > ?		/* Debug connector on the bottom of the board near SD card.
> > */
> > ?		status = "okay";
> > @@ -214,7 +220,7 @@
> > ?					regulator-always-on;
> > ?				};
> > ?
> > -				sd6 {
> > +				vdd_gpu: sd6 {
> > ?					regulator-name = "+VDD_GPU_AP";
> > ?					regulator-min-microvolt = <650000>;
> > ?					regulator-max-microvolt =
> > <1200000>;
> > 
> 
> Looks good to me. I see the following error when booting but looking at the
> code appears to be benign. Thierry, Alex, is this normal/okay?

I have the same messages and asked?Alexandre about them the other day. He told
me that it looks normal.

> [????5.715181] nouveau 57000000.gpu: NVIDIA GK20A
> (0ea000a1)????????????????????????????????????????????????????????????????????
> ????????????????????????
> [????5.720625] nouveau 57000000.gpu: imem: using
> IOMMU?????????????????????????????????????????????????????????????????????????
> ?????????????????????????
> [????5.803694] nouveau 57000000.gpu: DRM: VRAM: 0
> MiB???????????????????????????????????????????????????????????????????????????
> ????????????????????????
> [????5.808501] nouveau 57000000.gpu: DRM: GART: 1048576
> MiB???????????????????????????????????????????????????????????????????????????
> ??????????????????
> [????5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel,
> -22???????????????????????????????????????????????????????????????????????????
> ???
> [????5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies??
> 
> Cheers
> Jon
> 
-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160920/8b5aba3b/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-09-20 18:17   ` Paul Kocialkowski
@ 2016-09-21  7:57     ` Jon Hunter
  2016-11-07 12:51       ` Alexandre Courbot
  0 siblings, 1 reply; 7+ messages in thread
From: Jon Hunter @ 2016-09-21  7:57 UTC (permalink / raw)
  To: linux-arm-kernel


On 20/09/16 19:17, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
> 
> Le mardi 20 septembre 2016 ? 13:24 +0100, Jon Hunter a ?crit :
>> On 18/09/16 15:13, Paul Kocialkowski wrote:
>>>
>>> This enables the GPU node for tegra124 nyan boards, which is required to
>>> get graphics acceleration with nouveau on these devices.
>>>
>>> Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
>>> ---
>>>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> index dab9509..225ca77 100644
>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> @@ -42,6 +42,12 @@
>>>  		};
>>>  	};
>>>  
>>> +	gpu at 0,57000000 {
>>> +		status = "okay";
>>> +
>>> +		vdd-supply = <&vdd_gpu>;
>>> +	};
>>> +
>>>  	serial at 70006000 {
>>>  		/* Debug connector on the bottom of the board near SD card.
>>> */
>>>  		status = "okay";
>>> @@ -214,7 +220,7 @@
>>>  					regulator-always-on;
>>>  				};
>>>  
>>> -				sd6 {
>>> +				vdd_gpu: sd6 {
>>>  					regulator-name = "+VDD_GPU_AP";
>>>  					regulator-min-microvolt = <650000>;
>>>  					regulator-max-microvolt =
>>> <1200000>;
>>>
>>
>> Looks good to me. I see the following error when booting but looking at the
>> code appears to be benign. Thierry, Alex, is this normal/okay?
> 
> I have the same messages and asked Alexandre about them the other day. He told
> me that it looks normal.

Ok great. Hopefully, Alex can ACK then.

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-09-21  7:57     ` Jon Hunter
@ 2016-11-07 12:51       ` Alexandre Courbot
  2016-11-07 13:00         ` Jon Hunter
  0 siblings, 1 reply; 7+ messages in thread
From: Alexandre Courbot @ 2016-11-07 12:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter <jonathanh@nvidia•com> wrote:
>
> On 20/09/16 19:17, Paul Kocialkowski wrote:
>> * PGP Signed by an unknown key
>>
>> Le mardi 20 septembre 2016 ? 13:24 +0100, Jon Hunter a ?crit :
>>> On 18/09/16 15:13, Paul Kocialkowski wrote:
>>>>
>>>> This enables the GPU node for tegra124 nyan boards, which is required to
>>>> get graphics acceleration with nouveau on these devices.
>>>>
>>>> Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
>>>> ---
>>>>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>> index dab9509..225ca77 100644
>>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>> @@ -42,6 +42,12 @@
>>>>             };
>>>>     };
>>>>
>>>> +   gpu at 0,57000000 {
>>>> +           status = "okay";
>>>> +
>>>> +           vdd-supply = <&vdd_gpu>;
>>>> +   };
>>>> +
>>>>     serial at 70006000 {
>>>>             /* Debug connector on the bottom of the board near SD card.
>>>> */
>>>>             status = "okay";
>>>> @@ -214,7 +220,7 @@
>>>>                                     regulator-always-on;
>>>>                             };
>>>>
>>>> -                           sd6 {
>>>> +                           vdd_gpu: sd6 {
>>>>                                     regulator-name = "+VDD_GPU_AP";
>>>>                                     regulator-min-microvolt = <650000>;
>>>>                                     regulator-max-microvolt =
>>>> <1200000>;
>>>>
>>>
>>> Looks good to me. I see the following error when booting but looking at the
>>> code appears to be benign. Thierry, Alex, is this normal/okay?
>>
>> I have the same messages and asked Alexandre about them the other day. He told
>> me that it looks normal.
>
> Ok great. Hopefully, Alex can ACK then.

Apologies for the (very) delayed reply.

Yes, the messages you are seeing are part of the normal probe sequence
on Tegra. So this looks good to me.

Acked-by: Alexandre Courbot <acourbot@nvidia•com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-11-07 12:51       ` Alexandre Courbot
@ 2016-11-07 13:00         ` Jon Hunter
  0 siblings, 0 replies; 7+ messages in thread
From: Jon Hunter @ 2016-11-07 13:00 UTC (permalink / raw)
  To: linux-arm-kernel

Thierry,

On 07/11/16 12:51, Alexandre Courbot wrote:
> On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter <jonathanh@nvidia•com> wrote:
>>
>> On 20/09/16 19:17, Paul Kocialkowski wrote:
>>> * PGP Signed by an unknown key
>>>
>>> Le mardi 20 septembre 2016 ? 13:24 +0100, Jon Hunter a ?crit :
>>>> On 18/09/16 15:13, Paul Kocialkowski wrote:
>>>>>
>>>>> This enables the GPU node for tegra124 nyan boards, which is required to
>>>>> get graphics acceleration with nouveau on these devices.
>>>>>
>>>>> Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
>>>>> ---
>>>>>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>>>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>>> index dab9509..225ca77 100644
>>>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>>>> @@ -42,6 +42,12 @@
>>>>>             };
>>>>>     };
>>>>>
>>>>> +   gpu at 0,57000000 {
>>>>> +           status = "okay";
>>>>> +
>>>>> +           vdd-supply = <&vdd_gpu>;
>>>>> +   };
>>>>> +
>>>>>     serial at 70006000 {
>>>>>             /* Debug connector on the bottom of the board near SD card.
>>>>> */
>>>>>             status = "okay";
>>>>> @@ -214,7 +220,7 @@
>>>>>                                     regulator-always-on;
>>>>>                             };
>>>>>
>>>>> -                           sd6 {
>>>>> +                           vdd_gpu: sd6 {
>>>>>                                     regulator-name = "+VDD_GPU_AP";
>>>>>                                     regulator-min-microvolt = <650000>;
>>>>>                                     regulator-max-microvolt =
>>>>> <1200000>;
>>>>>
>>>>
>>>> Looks good to me. I see the following error when booting but looking at the
>>>> code appears to be benign. Thierry, Alex, is this normal/okay?
>>>
>>> I have the same messages and asked Alexandre about them the other day. He told
>>> me that it looks normal.
>>
>> Ok great. Hopefully, Alex can ACK then.
> 
> Apologies for the (very) delayed reply.
> 
> Yes, the messages you are seeing are part of the normal probe sequence
> on Tegra. So this looks good to me.
> 
> Acked-by: Alexandre Courbot <acourbot@nvidia•com>

Can you pick this one up for v4.10 as well?

Cheers
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
  2016-09-18 14:13 [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski
  2016-09-20 12:24 ` Jon Hunter
@ 2016-11-07 13:29 ` Thierry Reding
  1 sibling, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2016-11-07 13:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Sep 18, 2016 at 04:13:11PM +0200, Paul Kocialkowski wrote:
> This enables the GPU node for tegra124 nyan boards, which is required to
> get graphics acceleration with nouveau on these devices.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk•fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161107/edbcbb97/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-11-07 13:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-18 14:13 [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski
2016-09-20 12:24 ` Jon Hunter
2016-09-20 18:17   ` Paul Kocialkowski
2016-09-21  7:57     ` Jon Hunter
2016-11-07 12:51       ` Alexandre Courbot
2016-11-07 13:00         ` Jon Hunter
2016-11-07 13:29 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox