* [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss
@ 2016-12-14 8:57 Lokesh Vutla
2016-12-14 11:00 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Lokesh Vutla @ 2016-12-14 8:57 UTC (permalink / raw)
To: linux-arm-kernel
Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies
to this file. But it missed adding voltage supplies to usb_phy, mmc,
dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply
phandles to these nodes in dra72-evm-tps65917.dtsi
Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
Reported-by: Carlos Hernandez <ceh@ti•com>
Signed-off-by: Roger Quadros <rogerq@ti•com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti•com>
---
Logs:
- DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
- DRA72-evm revB: http://pastebin.ubuntu.com/23627658/
arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
index ee6dac44edf1..e6df676886c0 100644
--- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
+++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
@@ -132,3 +132,19 @@
ti,palmas-long-press-seconds = <6>;
};
};
+
+&usb2_phy1 {
+ phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {
+ phy-supply = <&ldo4_reg>;
+};
+
+&dss {
+ vdda_video-supply = <&ldo5_reg>;
+};
+
+&mmc1 {
+ vmmc_aux-supply = <&ldo1_reg>;
+};
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss
2016-12-14 8:57 [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss Lokesh Vutla
@ 2016-12-14 11:00 ` Roger Quadros
2016-12-14 12:35 ` Lokesh Vutla
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2016-12-14 11:00 UTC (permalink / raw)
To: linux-arm-kernel
Lokesh,
On 14/12/16 10:57, Lokesh Vutla wrote:
> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies
> to this file. But it missed adding voltage supplies to usb_phy, mmc,
> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply
> phandles to these nodes in dra72-evm-tps65917.dtsi
>
> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
> Reported-by: Carlos Hernandez <ceh@ti•com>
> Signed-off-by: Roger Quadros <rogerq@ti•com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti•com>
> ---
> Logs:
> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/
> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> index ee6dac44edf1..e6df676886c0 100644
> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> @@ -132,3 +132,19 @@
> ti,palmas-long-press-seconds = <6>;
> };
> };
> +
> +&usb2_phy1 {
> + phy-supply = <&ldo4_reg>;
> +};
> +
> +&usb2_phy2 {
> + phy-supply = <&ldo4_reg>;
> +};
> +
> +&dss {
> + vdda_video-supply = <&ldo5_reg>;
> +};
> +
> +&mmc1 {
> + vmmc_aux-supply = <&ldo1_reg>;
> +};
>
Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration?
If not I'd rather put this in the board dts files.
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss
2016-12-14 11:00 ` Roger Quadros
@ 2016-12-14 12:35 ` Lokesh Vutla
2016-12-14 12:46 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Lokesh Vutla @ 2016-12-14 12:35 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote:
> Lokesh,
>
> On 14/12/16 10:57, Lokesh Vutla wrote:
>> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
>> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies
>> to this file. But it missed adding voltage supplies to usb_phy, mmc,
>> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply
>> phandles to these nodes in dra72-evm-tps65917.dtsi
>>
>> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
>> Reported-by: Carlos Hernandez <ceh@ti•com>
>> Signed-off-by: Roger Quadros <rogerq@ti•com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti•com>
>> ---
>> Logs:
>> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
>> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/
>> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>> index ee6dac44edf1..e6df676886c0 100644
>> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>> @@ -132,3 +132,19 @@
>> ti,palmas-long-press-seconds = <6>;
>> };
>> };
>> +
>> +&usb2_phy1 {
>> + phy-supply = <&ldo4_reg>;
>> +};
>> +
>> +&usb2_phy2 {
>> + phy-supply = <&ldo4_reg>;
>> +};
>> +
>> +&dss {
>> + vdda_video-supply = <&ldo5_reg>;
>> +};
>> +
>> +&mmc1 {
>> + vmmc_aux-supply = <&ldo1_reg>;
>> +};
>>
>
> Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration?
> If not I'd rather put this in the board dts files.
hmm..This debate already happened when creating dra72-evm-tps65917 file
and concluded that all the common regulator stuff on dra72 evm revA,B,C
should go in this file. Any new board which is not similar to dra72-evm
will not be using this file.
Thanks and regards,
Lokesh
>
> cheers,
> -roger
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss
2016-12-14 12:35 ` Lokesh Vutla
@ 2016-12-14 12:46 ` Roger Quadros
2016-12-27 17:56 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2016-12-14 12:46 UTC (permalink / raw)
To: linux-arm-kernel
On 14/12/16 14:35, Lokesh Vutla wrote:
>
>
> On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote:
>> Lokesh,
>>
>> On 14/12/16 10:57, Lokesh Vutla wrote:
>>> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
>>> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies
>>> to this file. But it missed adding voltage supplies to usb_phy, mmc,
>>> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply
>>> phandles to these nodes in dra72-evm-tps65917.dtsi
>>>
>>> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
>>> Reported-by: Carlos Hernandez <ceh@ti•com>
>>> Signed-off-by: Roger Quadros <rogerq@ti•com>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti•com>
>>> ---
>>> Logs:
>>> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
>>> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/
>>> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>>> index ee6dac44edf1..e6df676886c0 100644
>>> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>>> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
>>> @@ -132,3 +132,19 @@
>>> ti,palmas-long-press-seconds = <6>;
>>> };
>>> };
>>> +
>>> +&usb2_phy1 {
>>> + phy-supply = <&ldo4_reg>;
>>> +};
>>> +
>>> +&usb2_phy2 {
>>> + phy-supply = <&ldo4_reg>;
>>> +};
>>> +
>>> +&dss {
>>> + vdda_video-supply = <&ldo5_reg>;
>>> +};
>>> +
>>> +&mmc1 {
>>> + vmmc_aux-supply = <&ldo1_reg>;
>>> +};
>>>
>>
>> Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration?
>> If not I'd rather put this in the board dts files.
>
> hmm..This debate already happened when creating dra72-evm-tps65917 file
> and concluded that all the common regulator stuff on dra72 evm revA,B,C
> should go in this file. Any new board which is not similar to dra72-evm
> will not be using this file.
OK, then it is fine. Thanks for clarifying.
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss
2016-12-14 12:46 ` Roger Quadros
@ 2016-12-27 17:56 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2016-12-27 17:56 UTC (permalink / raw)
To: linux-arm-kernel
* Roger Quadros <rogerq@ti•com> [161214 04:46]:
> On 14/12/16 14:35, Lokesh Vutla wrote:
> >
> >
> > On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote:
> >> Lokesh,
> >>
> >> On 14/12/16 10:57, Lokesh Vutla wrote:
> >>> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
> >>> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies
> >>> to this file. But it missed adding voltage supplies to usb_phy, mmc,
> >>> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply
> >>> phandles to these nodes in dra72-evm-tps65917.dtsi
> >>>
> >>> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")
> >>> Reported-by: Carlos Hernandez <ceh@ti•com>
> >>> Signed-off-by: Roger Quadros <rogerq@ti•com>
> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti•com>
> >>> ---
> >>> Logs:
> >>> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
> >>> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/
> >>> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
> >>> 1 file changed, 16 insertions(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> >>> index ee6dac44edf1..e6df676886c0 100644
> >>> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> >>> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi
> >>> @@ -132,3 +132,19 @@
> >>> ti,palmas-long-press-seconds = <6>;
> >>> };
> >>> };
> >>> +
> >>> +&usb2_phy1 {
> >>> + phy-supply = <&ldo4_reg>;
> >>> +};
> >>> +
> >>> +&usb2_phy2 {
> >>> + phy-supply = <&ldo4_reg>;
> >>> +};
> >>> +
> >>> +&dss {
> >>> + vdda_video-supply = <&ldo5_reg>;
> >>> +};
> >>> +
> >>> +&mmc1 {
> >>> + vmmc_aux-supply = <&ldo1_reg>;
> >>> +};
> >>>
> >>
> >> Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration?
> >> If not I'd rather put this in the board dts files.
> >
> > hmm..This debate already happened when creating dra72-evm-tps65917 file
> > and concluded that all the common regulator stuff on dra72 evm revA,B,C
> > should go in this file. Any new board which is not similar to dra72-evm
> > will not be using this file.
>
> OK, then it is fine. Thanks for clarifying.
Applying into omap-for-v4.10/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-27 17:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-14 8:57 [PATCH] ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss Lokesh Vutla
2016-12-14 11:00 ` Roger Quadros
2016-12-14 12:35 ` Lokesh Vutla
2016-12-14 12:46 ` Roger Quadros
2016-12-27 17:56 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox