From: briannorris@chromium•org (Brian Norris)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq
Date: Mon, 28 Aug 2017 15:44:49 -0700 [thread overview]
Message-ID: <20170828224447.GA3119@google.com> (raw)
In-Reply-To: <CAL_Jsq+MeiwOf=VDLZrxgPuLNEDvtGY=X-K1=6w9aaFVZgg1hA@mail.gmail.com>
On Mon, Aug 28, 2017 at 04:32:55PM -0500, Rob Herring wrote:
> On Fri, Aug 25, 2017 at 1:20 PM, Brian Norris <briannorris@chromium•org> wrote:
> > On Fri, Aug 25, 2017 at 01:14:39PM -0500, Rob Herring wrote:
> >> Use the wakeup source binding:
> >> Documentation/devicetree/bindings/power/wakeup-source.txt
> >
> > And I suppose this means we'd fall under this paragraph?
> >
> > "However if the devices have dedicated interrupt as the wakeup source
> > then they need to specify/identify the same using device specific
> > interrupt name. In such cases only that interrupt can be used as wakeup
> > interrupt."
> >
> > We don't expect *any* interrupt to qualify as PCI WAKE#; so we should
> > still also document the interrupt name ("wake"?) in
> > Documentation/devicetree/bindings/pci/pci.txt as Bjorn suggested, in
> > addition to using the 'wakeup-source' property documented there.
>
> I believe the defined interrupt name is "wakeup" as example 1 shows.
That's an example, not a definition. And the definition I quoted
literally says "device specific interrupt name". The PCIe specification
calls it "WAKE#" all over the place, so I figured that's a good name to
use.
"wakeup" is also fine I suppose, as long as we document that it must be
PCIe WAKE# signal, as per the PCIe specfication.
Brian
next prev parent reply other threads:[~2017-08-28 22:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 3:19 [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Jeffy Chen
2017-08-22 3:19 ` [PATCH v4 1/4] PCI: rockchip: Fix error handlings Jeffy Chen
2017-08-24 16:50 ` Bjorn Helgaas
2017-08-22 3:19 ` [PATCH v4 2/4] PCI: rockchip: Add support for pcie wake irq Jeffy Chen
2017-08-24 16:51 ` Bjorn Helgaas
2017-08-22 3:19 ` [PATCH v4 3/4] dt-bindings: " Jeffy Chen
2017-08-24 16:53 ` Bjorn Helgaas
2017-08-25 2:11 ` Brian Norris
2017-08-25 2:35 ` Shawn Lin
2017-08-25 13:57 ` Bjorn Helgaas
2017-08-25 18:14 ` Rob Herring
2017-08-25 18:20 ` Brian Norris
2017-08-28 21:32 ` Rob Herring
2017-08-28 22:44 ` Brian Norris [this message]
2017-08-22 3:19 ` [PATCH v4 4/4] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Jeffy Chen
2017-08-24 16:55 ` [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Bjorn Helgaas
2017-08-25 0:49 ` jeffy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828224447.GA3119@google.com \
--to=briannorris@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox