* [PATCH] perf: xgene: Fix IOB SLOW PMU parser error
@ 2018-06-06 21:06 Hoan Tran
2018-06-07 16:02 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Hoan Tran @ 2018-06-06 21:06 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the below parser error of the IOB SLOW PMU.
# perf stat -a -e iob-slow0/cycle-count/ sleep 1
evenf syntax error: 'iob-slow0/cycle-count/'
\___ parser error
It replaces the "-" character by "_" character inside the PMU name.
Signed-off-by: Hoan Tran <hoan.tran@amperecomputing•com>
---
drivers/perf/xgene_pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index 6bdb1da..0e31f13 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -1463,7 +1463,7 @@ static char *xgene_pmu_dev_name(struct device *dev, u32 type, int id)
case PMU_TYPE_IOB:
return devm_kasprintf(dev, GFP_KERNEL, "iob%d", id);
case PMU_TYPE_IOB_SLOW:
- return devm_kasprintf(dev, GFP_KERNEL, "iob-slow%d", id);
+ return devm_kasprintf(dev, GFP_KERNEL, "iob_slow%d", id);
case PMU_TYPE_MCB:
return devm_kasprintf(dev, GFP_KERNEL, "mcb%d", id);
case PMU_TYPE_MC:
--
2.7.4
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Ampere Computing or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. Any review, copying, or distribution of this email (or any attachments thereto) is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] perf: xgene: Fix IOB SLOW PMU parser error
2018-06-06 21:06 [PATCH] perf: xgene: Fix IOB SLOW PMU parser error Hoan Tran
@ 2018-06-07 16:02 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2018-06-07 16:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 06, 2018 at 02:06:54PM -0700, Hoan Tran wrote:
> This patch fixes the below parser error of the IOB SLOW PMU.
>
> # perf stat -a -e iob-slow0/cycle-count/ sleep 1
> evenf syntax error: 'iob-slow0/cycle-count/'
> \___ parser error
>
> It replaces the "-" character by "_" character inside the PMU name.
>
> Signed-off-by: Hoan Tran <hoan.tran@amperecomputing•com>
Hmm, why did you only notice this now? :(
Anyway, whilst this could in theory break something, we did this for the CPU
PMUs in the past without issues so I'll pick this up.
Cheers,
Will
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-07 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 21:06 [PATCH] perf: xgene: Fix IOB SLOW PMU parser error Hoan Tran
2018-06-07 16:02 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox