From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/5] net: add MTD support to eth_platform_get_mac_address()
Date: Wed, 18 Jul 2018 18:47:37 +0200 [thread overview]
Message-ID: <20180718164737.GE12477@lunn.ch> (raw)
In-Reply-To: <20180718161035.7005-6-brgl@bgdev.pl>
On Wed, Jul 18, 2018 at 06:10:35PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre•com>
>
> MTD doesn't support nvmem yet. Some platforms use MTD to read the MAC
> address from SPI flash. If we want this function to generalize reading
> the MAC address, we need to separately try to use MTD.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
> ---
> net/ethernet/eth.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index adf5bd03851f..f7dbd2cff7f9 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -55,6 +55,7 @@
> #include <linux/of_net.h>
> #include <linux/pci.h>
> #include <linux/nvmem-consumer.h>
> +#include <linux/mtd/mtd.h>
> #include <net/dst.h>
> #include <net/arp.h>
> #include <net/sock.h>
> @@ -573,6 +574,25 @@ int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr)
> }
> }
>
> +#ifdef CONFIG_MTD
> + /* NOTE: this should go away as soon as MTD gets nvmem support. */
> + if (!addr) {
> + struct mtd_info *mtd;
> + int rv;
> +
> + mtd = get_mtd_device_nm("MAC-Address");
In order for this to go away, you need to keep backwards
compatibility. When using nvmem, you look for a cell called
"mac-address". Here you are looking for "MAC-Address". That is going
to make backwards compatibility harder. How do you plan to do it?
Andrew
next prev parent reply other threads:[~2018-07-18 16:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 16:10 [PATCH 0/5] net: extend eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:10 ` [PATCH 1/5] net: visually shrink eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:28 ` Andrew Lunn
2018-07-18 16:31 ` Bartosz Golaszewski
2018-07-18 23:10 ` David Miller
2018-07-18 16:10 ` [PATCH 2/5] net: add an info message to eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:31 ` Andrew Lunn
2018-07-18 16:33 ` Bartosz Golaszewski
2018-07-18 23:13 ` David Miller
2018-07-18 16:10 ` [PATCH 3/5] net: fortify eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:35 ` Andrew Lunn
2018-07-18 16:10 ` [PATCH 4/5] net: add support for nvmem to eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:42 ` Andrew Lunn
2018-07-19 15:22 ` Andrew Lunn
2018-07-19 15:25 ` Bartosz Golaszewski
2018-07-19 17:47 ` Russell King - ARM Linux
2018-07-19 21:24 ` Bartosz Golaszewski
2018-07-19 21:48 ` Andrew Lunn
2018-07-18 16:10 ` [PATCH 5/5] net: add MTD support " Bartosz Golaszewski
2018-07-18 16:47 ` Andrew Lunn [this message]
2018-07-18 16:54 ` Bartosz Golaszewski
2018-07-18 17:03 ` Andrew Lunn
2018-07-19 8:14 ` Bartosz Golaszewski
2018-07-19 15:01 ` Andrew Lunn
2018-07-19 15:07 ` Bartosz Golaszewski
2018-07-19 15:27 ` Andrew Lunn
2018-07-19 15:35 ` Bartosz Golaszewski
2018-07-20 5:17 ` Sekhar Nori
2018-07-20 14:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718164737.GE12477@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox