From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/5] net: add MTD support to eth_platform_get_mac_address()
Date: Thu, 19 Jul 2018 17:01:38 +0200 [thread overview]
Message-ID: <20180719150138.GC9119@lunn.ch> (raw)
In-Reply-To: <CAMRc=Md3oeEktzrA9UZyNPX6pB4bG+Gv0o6cjbs0UUKb3sYTsA@mail.gmail.com>
On Thu, Jul 19, 2018 at 10:14:29AM +0200, Bartosz Golaszewski wrote:
> 2018-07-18 19:03 GMT+02:00 Andrew Lunn <andrew@lunn•ch>:
> >> >> +#ifdef CONFIG_MTD
> >> >> + /* NOTE: this should go away as soon as MTD gets nvmem support. */
> >> >> + if (!addr) {
> >> >> + struct mtd_info *mtd;
> >> >> + int rv;
> >> >> +
> >> >> + mtd = get_mtd_device_nm("MAC-Address");
> >> >
> >> > In order for this to go away, you need to keep backwards
> >> > compatibility. When using nvmem, you look for a cell called
> >> > "mac-address". Here you are looking for "MAC-Address". That is going
> >> > to make backwards compatibility harder. How do you plan to do it?
> >> >
> >> > Andrew
> >>
> >> I'm trying to adjust to already existing users. The only user of
> >> get_mtd_device_nm() who calls it to read the MAC address registers a
> >> partition called "MAC-Address". We can't change it since it's visible
> >> from user space. In the future we'd just have to have a list of
> >> supported string that we'd use to do the nvmem lookup.
> >
> > Why not have the nvmem cell called "MAC-Address"? When you add nvmem
> > support to MTD, i assume you are going to map each MTD partition to an
> > nvmem cell?
>
> Because all existing users of nvmem use "mac-address" as the name of
> this cell already. I guess we will need to live with both in this
> particular function.
So i'm not convinced this last patch is making things better. I would
prefer if it was dropped for the moment. Wait until MTD via nvmem is
actually implemented and there is a concrete concept of how a MAC
address would be looked up without having lots of ugly code.
Andrew
next prev parent reply other threads:[~2018-07-19 15:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 16:10 [PATCH 0/5] net: extend eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:10 ` [PATCH 1/5] net: visually shrink eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:28 ` Andrew Lunn
2018-07-18 16:31 ` Bartosz Golaszewski
2018-07-18 23:10 ` David Miller
2018-07-18 16:10 ` [PATCH 2/5] net: add an info message to eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:31 ` Andrew Lunn
2018-07-18 16:33 ` Bartosz Golaszewski
2018-07-18 23:13 ` David Miller
2018-07-18 16:10 ` [PATCH 3/5] net: fortify eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:35 ` Andrew Lunn
2018-07-18 16:10 ` [PATCH 4/5] net: add support for nvmem to eth_platform_get_mac_address() Bartosz Golaszewski
2018-07-18 16:42 ` Andrew Lunn
2018-07-19 15:22 ` Andrew Lunn
2018-07-19 15:25 ` Bartosz Golaszewski
2018-07-19 17:47 ` Russell King - ARM Linux
2018-07-19 21:24 ` Bartosz Golaszewski
2018-07-19 21:48 ` Andrew Lunn
2018-07-18 16:10 ` [PATCH 5/5] net: add MTD support " Bartosz Golaszewski
2018-07-18 16:47 ` Andrew Lunn
2018-07-18 16:54 ` Bartosz Golaszewski
2018-07-18 17:03 ` Andrew Lunn
2018-07-19 8:14 ` Bartosz Golaszewski
2018-07-19 15:01 ` Andrew Lunn [this message]
2018-07-19 15:07 ` Bartosz Golaszewski
2018-07-19 15:27 ` Andrew Lunn
2018-07-19 15:35 ` Bartosz Golaszewski
2018-07-20 5:17 ` Sekhar Nori
2018-07-20 14:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719150138.GC9119@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox