From: Thomas Petazzoni <thomas.petazzoni@bootlin•com>
To: Heinrich Schuchardt <xypron.glpk@gmx•de>
Cc: Mark Rutland <mark.rutland@arm•com>, Andrew Lunn <andrew@lunn•ch>,
Jason Cooper <jason@lakedaemon•net>,
devicetree@vger•kernel.org,
Gregory Clement <gregory.clement@bootlin•com>,
Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, Rob Herring <robh+dt@kernel•org>,
linux-arm-kernel@lists•infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH 1/1] arm64: dts: marvell: mcbin: enlarge PCI memory window
Date: Mon, 20 May 2019 17:54:10 +0200 [thread overview]
Message-ID: <20190520175410.4c941bfc@windsurf> (raw)
In-Reply-To: <20190517161123.9293-1-xypron.glpk@gmx.de>
Hello Heinrich,
On Fri, 17 May 2019 18:11:23 +0200
Heinrich Schuchardt <xypron.glpk@gmx•de> wrote:
> Running a graphics adapter on the MACCHIATObin fails due to an
> insufficently sized memory window.
>
> Enlarge the memory window for the PCIe slot to 512 MiB.
>
> With the patch I am able to use a GT710 graphics adapter with 1 GB onboard
> memory.
>
> These are the mapped memory areas that the graphics adapter is actually
> using:
>
> Region 0: Memory at cc000000 (32-bit, non-prefetchable) [size=16M]
> Region 1: Memory at c0000000 (64-bit, prefetchable) [size=128M]
> Region 3: Memory at c8000000 (64-bit, prefetchable) [size=32M]
> Region 5: I/O ports at 1000 [size=128]
> Expansion ROM at ca000000 [disabled] [size=512K]
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx•de>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index 329f8ceeebea..205071b45a32 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -184,6 +184,8 @@
> num-lanes = <4>;
> num-viewport = <8>;
> reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> + ranges = <0x81000000 0x0 0xf9010000 0x0 0xf9010000 0x0 0x10000
> + 0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>;
While I understand the change, I find it is a bit of a "one-off"
solution, which will only work specifically for the MacchiatoBin. But
admittedly, there isn't really a good generic solution: depending on
the number of PCIe ports and what you connect to them, you will need
windows of different sizes.
On older Armada platforms, it works a bit better because we have a
single PCIe MEM aperture and a single PCIe I/O aperture, from which all
PCIe ports allocate: each PCIe interface is a child bus of an emulated
root port.
Unfortunately, on Armada 7K/8K, each PCIe interface is seen as an
independent root complex, so we have one PCIe I/O aperture and one PCIe
MEM aperture for each.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-20 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:11 [PATCH 1/1] arm64: dts: marvell: mcbin: enlarge PCI memory window Heinrich Schuchardt
2019-05-17 20:08 ` Gregory CLEMENT
2019-05-17 20:55 ` Heinrich Schuchardt
2019-05-17 21:26 ` Gregory CLEMENT
2019-05-20 15:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520175410.4c941bfc@windsurf \
--to=thomas.petazzoni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=xypron.glpk@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox