* [PATCH 2/3] clk: imx8mq: add SNVS clock to clock tree
2019-05-15 1:09 [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Anson Huang
@ 2019-05-15 1:09 ` Anson Huang
2019-05-23 0:59 ` Shawn Guo
2019-05-15 1:09 ` [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node Anson Huang
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Anson Huang @ 2019-05-15 1:09 UTC (permalink / raw)
To: robh+dt@kernel•org, mark.rutland@arm•com, shawnguo@kernel•org,
s.hauer@pengutronix•de, kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, sboyd@kernel•org, l.stach@pengutronix•de,
Abel Vesa, andrew.smirnov@gmail•com, ccaione@baylibre•com,
angus@akkea•ca, agx@sigxcpu•org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org
Cc: dl-linux-imx
i.MX8MQ has clock gate for SNVS module, add it into clock tree
for SNVS RTC driver to manage.
Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
---
drivers/clk/imx/clk-imx8mq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index daf1841..24c3464 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -507,6 +507,7 @@ static int imx8mq_clocks_probe(struct platform_device *pdev)
clks[IMX8MQ_CLK_SAI5_IPG] = imx_clk_gate2_shared2("sai5_ipg_clk", "ipg_audio_root", base + 0x4370, 0, &share_count_sai5);
clks[IMX8MQ_CLK_SAI6_ROOT] = imx_clk_gate2_shared2("sai6_root_clk", "sai6", base + 0x4380, 0, &share_count_sai6);
clks[IMX8MQ_CLK_SAI6_IPG] = imx_clk_gate2_shared2("sai6_ipg_clk", "ipg_audio_root", base + 0x4380, 0, &share_count_sai6);
+ clks[IMX8MQ_CLK_SNVS_ROOT] = imx_clk_gate4("snvs_root_clk", "ipg_root", base + 0x4470, 0);
clks[IMX8MQ_CLK_UART1_ROOT] = imx_clk_gate4("uart1_root_clk", "uart1", base + 0x4490, 0);
clks[IMX8MQ_CLK_UART2_ROOT] = imx_clk_gate4("uart2_root_clk", "uart2", base + 0x44a0, 0);
clks[IMX8MQ_CLK_UART3_ROOT] = imx_clk_gate4("uart3_root_clk", "uart3", base + 0x44b0, 0);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] clk: imx8mq: add SNVS clock to clock tree
2019-05-15 1:09 ` [PATCH 2/3] clk: imx8mq: add SNVS clock to clock tree Anson Huang
@ 2019-05-23 0:59 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-05-23 0:59 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org, agx@sigxcpu•org,
Abel Vesa, ccaione@baylibre•com, sboyd@kernel•org,
s.hauer@pengutronix•de, angus@akkea•ca,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
andrew.smirnov@gmail•com, robh+dt@kernel•org, dl-linux-imx,
kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, linux-arm-kernel@lists•infradead.org,
l.stach@pengutronix•de
On Wed, May 15, 2019 at 01:09:30AM +0000, Anson Huang wrote:
> i.MX8MQ has clock gate for SNVS module, add it into clock tree
> for SNVS RTC driver to manage.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node
2019-05-15 1:09 [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Anson Huang
2019-05-15 1:09 ` [PATCH 2/3] clk: imx8mq: add SNVS clock to clock tree Anson Huang
@ 2019-05-15 1:09 ` Anson Huang
2019-05-23 1:02 ` Shawn Guo
2019-05-15 10:21 ` [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Leonard Crestez
2019-05-23 0:58 ` Shawn Guo
3 siblings, 1 reply; 8+ messages in thread
From: Anson Huang @ 2019-05-15 1:09 UTC (permalink / raw)
To: robh+dt@kernel•org, mark.rutland@arm•com, shawnguo@kernel•org,
s.hauer@pengutronix•de, kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, sboyd@kernel•org, l.stach@pengutronix•de,
Abel Vesa, andrew.smirnov@gmail•com, ccaione@baylibre•com,
angus@akkea•ca, agx@sigxcpu•org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org
Cc: dl-linux-imx
i.MX8MQ has clock gate for SNVS module, add clock info to SNVS
RTC node for clock management.
Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index e5f3133..b706de8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -438,6 +438,8 @@
offset = <0x34>;
interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_SNVS_ROOT>;
+ clock-names = "snvs-rtc";
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node
2019-05-15 1:09 ` [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node Anson Huang
@ 2019-05-23 1:02 ` Shawn Guo
2019-05-24 5:52 ` Anson Huang
0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2019-05-23 1:02 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org, agx@sigxcpu•org,
Abel Vesa, ccaione@baylibre•com, sboyd@kernel•org,
s.hauer@pengutronix•de, angus@akkea•ca,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
andrew.smirnov@gmail•com, robh+dt@kernel•org, dl-linux-imx,
kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, linux-arm-kernel@lists•infradead.org,
l.stach@pengutronix•de
On Wed, May 15, 2019 at 01:09:36AM +0000, Anson Huang wrote:
> i.MX8MQ has clock gate for SNVS module, add clock info to SNVS
> RTC node for clock management.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
This one still has problem with encoding and thus cannot be applied.
Here is what I get, and there is '=20' in the patch content.
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dt=
s/freescale/imx8mq.dtsi
index e5f3133..b706de8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -438,6 +438,8 @@
offset =3D <0x34>;
interrupts =3D <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+ clocks =3D <&clk IMX8MQ_CLK_SNVS_ROOT>;
+ clock-names =3D "snvs-rtc";
};
};
=20
--=20
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* RE: [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node
2019-05-23 1:02 ` Shawn Guo
@ 2019-05-24 5:52 ` Anson Huang
0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-05-24 5:52 UTC (permalink / raw)
To: Shawn Guo
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org, agx@sigxcpu•org,
Abel Vesa, ccaione@baylibre•com, sboyd@kernel•org,
s.hauer@pengutronix•de, angus@akkea•ca,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
andrew.smirnov@gmail•com, robh+dt@kernel•org, dl-linux-imx,
kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, linux-arm-kernel@lists•infradead.org,
l.stach@pengutronix•de
Hi, Shawn
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel•org]
> Sent: Thursday, May 23, 2019 9:03 AM
> To: Anson Huang <anson.huang@nxp•com>
> Cc: robh+dt@kernel•org; mark.rutland@arm•com; s.hauer@pengutronix•de;
> kernel@pengutronix•de; festevam@gmail•com; mturquette@baylibre•com;
> sboyd@kernel•org; l.stach@pengutronix•de; Abel Vesa
> <abel.vesa@nxp•com>; andrew.smirnov@gmail•com; ccaione@baylibre•com;
> angus@akkea•ca; agx@sigxcpu•org; devicetree@vger•kernel.org; linux-arm-
> kernel@lists•infradead.org; linux-kernel@vger•kernel.org; linux-
> clk@vger•kernel.org; dl-linux-imx <linux-imx@nxp•com>
> Subject: Re: [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node
>
> On Wed, May 15, 2019 at 01:09:36AM +0000, Anson Huang wrote:
> > i.MX8MQ has clock gate for SNVS module, add clock info to SNVS RTC
> > node for clock management.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
>
> This one still has problem with encoding and thus cannot be applied.
> Here is what I get, and there is '=20' in the patch content.
We switch to another server which has no such issue, I resent the patch,
Please pick up this one, sorry for the inconvenience.
https://patchwork.kernel.org/patch/10959097/
thanks,
Anson.
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dt= s/freescale/imx8mq.dtsi index e5f3133..b706de8
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -438,6 +438,8 @@
> offset =3D <0x34>;
> interrupts =3D <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> + clocks =3D <&clk IMX8MQ_CLK_SNVS_ROOT>;
> + clock-names =3D "snvs-rtc";
> };
> };
> =20
> --=20
> 2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock
2019-05-15 1:09 [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Anson Huang
2019-05-15 1:09 ` [PATCH 2/3] clk: imx8mq: add SNVS clock to clock tree Anson Huang
2019-05-15 1:09 ` [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node Anson Huang
@ 2019-05-15 10:21 ` Leonard Crestez
2019-05-23 0:58 ` Shawn Guo
3 siblings, 0 replies; 8+ messages in thread
From: Leonard Crestez @ 2019-05-15 10:21 UTC (permalink / raw)
To: Anson Huang, shawnguo@kernel•org, sboyd@kernel•org
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org, agx@sigxcpu•org,
Abel Vesa, ccaione@baylibre•com, andrew.smirnov@gmail•com,
s.hauer@pengutronix•de, angus@akkea•ca,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
robh+dt@kernel•org, dl-linux-imx, kernel@pengutronix•de,
festevam@gmail•com, mturquette@baylibre•com,
linux-arm-kernel@lists•infradead.org, l.stach@pengutronix•de
On 15.05.2019 04:09, Anson Huang wrote:
> Add macro for the SNVS clock of the i.MX8MQ.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
For series (couldn't find a cover letter):
Reviewed-by: Leonard Crestez <leonard.crestez@nxp•com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock
2019-05-15 1:09 [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Anson Huang
` (2 preceding siblings ...)
2019-05-15 10:21 ` [PATCH 1/3] dt-bindings: clock: imx8mq: Add SNVS clock Leonard Crestez
@ 2019-05-23 0:58 ` Shawn Guo
3 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-05-23 0:58 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org, agx@sigxcpu•org,
Abel Vesa, ccaione@baylibre•com, sboyd@kernel•org,
s.hauer@pengutronix•de, angus@akkea•ca,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
andrew.smirnov@gmail•com, robh+dt@kernel•org, dl-linux-imx,
kernel@pengutronix•de, festevam@gmail•com,
mturquette@baylibre•com, linux-arm-kernel@lists•infradead.org,
l.stach@pengutronix•de
On Wed, May 15, 2019 at 01:09:24AM +0000, Anson Huang wrote:
> Add macro for the SNVS clock of the i.MX8MQ.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread