public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
* [PATCH] net: stmmac: Use netif_tx_napi_add() for TX polling function
@ 2019-07-30 11:38 Bartosz Golaszewski
  2019-07-31 23:10 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-07-30 11:38 UTC (permalink / raw)
  To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
	David S . Miller, Maxime Coquelin
  Cc: Frode Isaksen, netdev, linux-kernel, Bartosz Golaszewski,
	linux-stm32, linux-arm-kernel

From: Frode Isaksen <fisaksen@baylibre•com>

This variant of netif_napi_add() should be used from drivers
using NAPI to exclusively poll a TX queue.

Signed-off-by: Frode Isaksen <fisaksen@baylibre•com>
Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 98b1a5c6d537..390dad5b9819 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4313,8 +4313,9 @@ int stmmac_dvr_probe(struct device *device,
 				       NAPI_POLL_WEIGHT);
 		}
 		if (queue < priv->plat->tx_queues_to_use) {
-			netif_napi_add(ndev, &ch->tx_napi, stmmac_napi_poll_tx,
-				       NAPI_POLL_WEIGHT);
+			netif_tx_napi_add(ndev, &ch->tx_napi,
+					  stmmac_napi_poll_tx,
+					  NAPI_POLL_WEIGHT);
 		}
 	}
 
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: stmmac: Use netif_tx_napi_add() for TX polling function
  2019-07-30 11:38 [PATCH] net: stmmac: Use netif_tx_napi_add() for TX polling function Bartosz Golaszewski
@ 2019-07-31 23:10 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-31 23:10 UTC (permalink / raw)
  To: brgl
  Cc: fisaksen, alexandre.torgue, netdev, linux-kernel, bgolaszewski,
	joabreu, mcoquelin.stm32, peppe.cavallaro, linux-stm32,
	linux-arm-kernel

From: Bartosz Golaszewski <brgl@bgdev•pl>
Date: Tue, 30 Jul 2019 13:38:14 +0200

> From: Frode Isaksen <fisaksen@baylibre•com>
> 
> This variant of netif_napi_add() should be used from drivers
> using NAPI to exclusively poll a TX queue.
> 
> Signed-off-by: Frode Isaksen <fisaksen@baylibre•com>
> Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre•com>

Applied and queued up for -stable.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-31 23:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-30 11:38 [PATCH] net: stmmac: Use netif_tx_napi_add() for TX polling function Bartosz Golaszewski
2019-07-31 23:10 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox