Re: [PATCH V6 1/2] mm/page_alloc: Make alloc_gigantic_page() available for general use

From: Michal Hocko <mhocko@kernel•org>
To: David Hildenbrand <david@redhat•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
	linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
	Peter Zijlstra <peterz@infradead•org>,
	James Hogan <jhogan@kernel•org>,
	Tetsuo Handa <penguin-kernel@i-love•sakura.ne.jp>,
	Heiko Carstens <heiko.carstens@de•ibm.com>,
	linux-kernel@vger•kernel.org, linux-mm@kvack•org,
	Paul Mackerras <paulus@samba•org>,
	sparclinux@vger•kernel.org, Thomas Gleixner <tglx@linutronix•de>,
	Andrea Arcangeli <aarcange@redhat•com>,
	linux-s390@vger•kernel.org, Michael Ellerman <mpe@ellerman•id.au>,
	x86@kernel•org, Russell King - ARM Linux <linux@armlinux•org.uk>,
	Matthew Wilcox <willy@infradead•org>,
	Steven Price <Steven.Price@arm•com>,
	Jason Gunthorpe <jgg@ziepe•ca>,
	Gerald Schaefer <gerald.schaefer@de•ibm.com>,
	David Rientjes <rientjes@google•com>,
	linux-snps-arc@lists•infradead.org,
	linux-arm-kernel@lists•infradead.org,
	Kees Cook <keescook@chromium•org>,
	Anshuman Khandual <anshuman.khandual@arm•com>,
	Masahiro Yamada <yamada.masahiro@socionext•com>,
	linuxppc-dev@lists•ozlabs.org, Mark Brown <broonie@kernel•org>,
	"Kirill A . Shutemov" <kirill@shutemov•name>,
	Dan Williams <dan.j.williams@intel•com>,
	Vlastimil Babka <vbabka@suse•cz>,
	Oscar Salvador <osalvador@suse•de>,
	Christophe Leroy <christophe.leroy@c-s•fr>,
	Sri Krishna chowdary <schowdary@nvidia•com>,
	Ard Biesheuvel <ard.biesheuvel@linaro•org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Dave Hansen <dave.hansen@intel•com>,
	linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
	Paul Burton <paul.burton@mips•com>,
	Mike Rapoport <rppt@linux•vnet.ibm.com>,
	Vineet Gupta <vgupta@synopsys•com>,
	Martin Schwidefsky <schwidefsky@de•ibm.com>,
	Andrew Morton <akpm@linux-foundation•org>,
	Mel Gorman <mgorman@techsingularity•net>,
	"David S. Miller" <davem@davemloft•net>,
	Mike Kravetz <mike.kravetz@oracle•com>
Subject: Re: [PATCH V6 1/2] mm/page_alloc: Make alloc_gigantic_page() available for general use
Date: Tue, 15 Oct 2019 14:11:45 +0200	[thread overview]
Message-ID: <20191015121145.GG317@dhcp22.suse.cz> (raw)
In-Reply-To: <20191015120956.GF317@dhcp22.suse.cz>

On Tue 15-10-19 14:09:56, Michal Hocko wrote:
> On Tue 15-10-19 13:50:02, David Hildenbrand wrote:
> > On 15.10.19 13:47, Michal Hocko wrote:
> > > On Tue 15-10-19 13:42:03, David Hildenbrand wrote:
> > > [...]
> > > > > -static bool pfn_range_valid_gigantic(struct zone *z,
> > > > > -			unsigned long start_pfn, unsigned long nr_pages)
> > > > > -{
> > > > > -	unsigned long i, end_pfn = start_pfn + nr_pages;
> > > > > -	struct page *page;
> > > > > -
> > > > > -	for (i = start_pfn; i < end_pfn; i++) {
> > > > > -		if (!pfn_valid(i))
> > > > > -			return false;
> > > > > -
> > > > > -		page = pfn_to_page(i);
> > > > 
> > > > Am I missing something or should here really be a pfn_to_online_page() here
> > > > instead of a pfn_valid() ?
> > > 
> > > http://lkml.kernel.org/r/20180423000943.GO17484@dhcp22.suse.cz
> > > 
> > 
> > So we managed to add PageReserved(page) but not pfn_to_online_page(). But it
> > is the right thing to do? (or am I missing something?)
> 
> Yeah, pfn_to_online_page is better. But please note that this is an
> optimistic check. The real check has to be done when isolating the
> pageblock because things might change in the meantime.

Except I have missed that we do get zone from the page and other
undefined state. Scratch my above comment.
-- 
Michal Hocko
SUSE Labs

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel