From: David Hildenbrand <david@redhat•com>
To: Michal Hocko <mhocko@kernel•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
Peter Zijlstra <peterz@infradead•org>,
James Hogan <jhogan@kernel•org>,
Tetsuo Handa <penguin-kernel@i-love•sakura.ne.jp>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
Paul Mackerras <paulus@samba•org>,
sparclinux@vger•kernel.org, Thomas Gleixner <tglx@linutronix•de>,
Andrea Arcangeli <aarcange@redhat•com>,
linux-s390@vger•kernel.org, Michael Ellerman <mpe@ellerman•id.au>,
x86@kernel•org, Russell King - ARM Linux <linux@armlinux•org.uk>,
Matthew Wilcox <willy@infradead•org>,
Steven Price <Steven.Price@arm•com>,
Jason Gunthorpe <jgg@ziepe•ca>,
Gerald Schaefer <gerald.schaefer@de•ibm.com>,
David Rientjes <rientjes@google•com>,
linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
Kees Cook <keescook@chromium•org>,
Anshuman Khandual <anshuman.khandual@arm•com>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
linuxppc-dev@lists•ozlabs.org, Mark Brown <broonie@kernel•org>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
Dan Williams <dan.j.williams@intel•com>,
Vlastimil Babka <vbabka@suse•cz>,
Oscar Salvador <osalvador@suse•de>,
Christophe Leroy <christophe.leroy@c-s•fr>,
Sri Krishna chowdary <schowdary@nvidia•com>,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Dave Hansen <dave.hansen@intel•com>,
linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
Paul Burton <paul.burton@mips•com>,
Mike Rapoport <rppt@linux•vnet.ibm.com>,
Vineet Gupta <vgupta@synopsys•com>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
Mel Gorman <mgorman@techsingularity•net>,
"David S. Miller" <davem@davemloft•net>,
Mike Kravetz <mike.kravetz@oracle•com>
Subject: Re: [PATCH V6 1/2] mm/page_alloc: Make alloc_gigantic_page() available for general use
Date: Tue, 15 Oct 2019 14:01:27 +0200 [thread overview]
Message-ID: <3eaa50db-0b66-9d9d-3293-77216f3df91e@redhat.com> (raw)
In-Reply-To: <513bc2f7-8110-58f7-36c1-a04b59f11f7e@redhat.com>
On 15.10.19 13:50, David Hildenbrand wrote:
> On 15.10.19 13:47, Michal Hocko wrote:
>> On Tue 15-10-19 13:42:03, David Hildenbrand wrote:
>> [...]
>>>> -static bool pfn_range_valid_gigantic(struct zone *z,
>>>> - unsigned long start_pfn, unsigned long nr_pages)
>>>> -{
>>>> - unsigned long i, end_pfn = start_pfn + nr_pages;
>>>> - struct page *page;
>>>> -
>>>> - for (i = start_pfn; i < end_pfn; i++) {
>>>> - if (!pfn_valid(i))
>>>> - return false;
>>>> -
>>>> - page = pfn_to_page(i);
>>>
>>> Am I missing something or should here really be a pfn_to_online_page() here
>>> instead of a pfn_valid() ?
>>
>> http://lkml.kernel.org/r/20180423000943.GO17484@dhcp22.suse.cz
>>
>
> So we managed to add PageReserved(page) but not pfn_to_online_page().
> But it is the right thing to do? (or am I missing something?)
>
Will send a patch.
--
Thanks,
David / dhildenb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-15 12:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 9:21 [PATCH V6 0/2] mm/debug: Add tests validating architecture page table helpers Anshuman Khandual
2019-10-15 9:21 ` [PATCH V6 1/2] mm/page_alloc: Make alloc_gigantic_page() available for general use Anshuman Khandual
2019-10-15 10:45 ` Michal Hocko
2019-10-15 11:07 ` Anshuman Khandual
2019-10-15 11:42 ` David Hildenbrand
2019-10-15 11:47 ` Michal Hocko
2019-10-15 11:50 ` David Hildenbrand
2019-10-15 12:01 ` David Hildenbrand [this message]
2019-10-15 12:09 ` Michal Hocko
2019-10-15 12:11 ` Michal Hocko
2019-10-15 9:21 ` [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers Anshuman Khandual
2019-10-15 11:46 ` Michal Hocko
2019-10-15 12:27 ` Anshuman Khandual
2019-10-15 18:09 ` Qian Cai
2019-10-16 9:54 ` Anshuman Khandual
2019-10-15 14:41 ` [PATCH V6 0/2] " Qian Cai
2019-10-15 15:21 ` Anshuman Khandual
2019-10-15 18:42 ` Qian Cai
2019-10-16 8:59 ` Anshuman Khandual
2019-10-16 8:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eaa50db-0b66-9d9d-3293-77216f3df91e@redhat.com \
--to=david@redhat$(echo .)com \
--cc=Steven.Price@arm$(echo .)com \
--cc=aarcange@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gerald.schaefer@de$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jhogan@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mhocko@kernel$(echo .)org \
--cc=mike.kravetz@oracle$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=osalvador@suse$(echo .)de \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=penguin-kernel@i-love$(echo .)sakura.ne.jp \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=schowdary@nvidia$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@synopsys$(echo .)com \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox