From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Yingjoe Chen <yingjoe.chen@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>, Jacky Bai <ping.bai@nxp•com>,
wsd_upstream@mediatek•com, Stefan Agner <stefan@agner•cn>,
Catalin Marinas <catalin.marinas@arm•com>,
Marco Felsch <m.felsch@pengutronix•de>,
Leonard Crestez <leonard.crestez@nxp•com>,
Will Deacon <will@kernel•org>, Anson Huang <Anson.Huang@nxp•com>,
YueHaibing <yuehaibing@huawei•com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro•org>,
linux-input@vger•kernel.org, Thierry Reding <treding@nvidia•com>,
Valentin Schneider <valentin.schneider@arm•com>,
devicetree@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
Maxime Ripard <mripard@kernel•org>,
Mark Brown <broonie@kernel•org>,
linux-mediatek@lists•infradead.org,
Matthias Brugger <matthias.bgg@gmail•com>,
linux-arm-kernel@lists•infradead.org,
Aisheng Dong <aisheng.dong@nxp•com>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
linux-kernel@vger•kernel.org, Dinh Nguyen <dinguyen@kernel•org>,
Rob Herring <robh+dt@kernel•org>, Olof Johansson <olof@lixom•net>,
fengping yu <fengping.yu@mediatek•com>,
Shawn Guo <shawnguo@kernel•org>
Subject: Re: [PATCH V2 2/2] drivers: input: keyboard
Date: Wed, 8 Jan 2020 13:26:09 +0200 [thread overview]
Message-ID: <20200108112609.GN32742@smile.fi.intel.com> (raw)
In-Reply-To: <1578473162.12131.13.camel@mtksdaap41>
On Wed, Jan 08, 2020 at 04:46:02PM +0800, Yingjoe Chen wrote:
> On Wed, 2020-01-08 at 14:29 +0800, fengping yu wrote:
> > + tasklet_init(&keypad->tasklet, kpd_keymap_handler,
> > + (unsigned long)keypad);
> > +
> > + writew((u16)(keypad->key_debounce & KPD_DEBOUNCE_MASK),
> > + keypad->base + KP_DEBOUNCE);
>
> You use a 13 bits mask and set it directly to KP_DEBOUNCE register. Are
> you sure the debounce unit is ms?
>
> > +
> > + /* register IRQ */
> > + err = request_irq(keypad->irqnr, kpd_irq_handler, IRQF_TRIGGER_NONE,
> > + KPD_NAME, keypad);
>
> please consider using devm_request_irq, otherwise you have to free it in
> _remove function.
No, you may not use devm_*_irq() when tasklets are in use. There is a nasty
race condition.
Actually the rule of thumb is to NOT use devm_*_irq() unless you exactly know
what you are doing.
P.S. Why simple not to switch to threaded IRQ handler and drop tasklet? In such
case devm_*_irq() is fine.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-08 11:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 6:29 Resend [PATCH V2] dt-bindings:input:keyboard:add MediaTek keypad controller binding fengping yu
2020-01-08 6:29 ` [PATCH V2 1/2] Documentation: devicetree: bindings: input fengping yu
2020-01-10 1:16 ` Dmitry Torokhov
2020-01-08 6:29 ` [PATCH V2 2/2] drivers: input: keyboard fengping yu
2020-01-08 7:11 ` Marco Felsch
2020-01-08 7:23 ` Marco Felsch
2020-01-08 8:46 ` Yingjoe Chen
2020-01-08 11:26 ` Andy Shevchenko [this message]
2020-01-10 1:20 ` Dmitry Torokhov
2020-01-08 11:22 ` Andy Shevchenko
2020-01-10 1:32 ` Dmitry Torokhov
2020-01-10 7:35 ` Andy Shevchenko
2020-01-08 6:38 ` Resend [PATCH V2] dt-bindings:input:keyboard:add MediaTek keypad controller binding Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108112609.GN32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=Anson.Huang@nxp$(echo .)com \
--cc=aisheng.dong@nxp$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dinguyen@kernel$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=fengping.yu@mediatek$(echo .)com \
--cc=leonard.crestez@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=marcin.juszkiewicz@linaro$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=ping.bai@nxp$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=stefan@agner$(echo .)cn \
--cc=treding@nvidia$(echo .)com \
--cc=valentin.schneider@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=wsd_upstream@mediatek$(echo .)com \
--cc=yingjoe.chen@mediatek$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox