Re: [PATCH V2 1/2] Documentation: devicetree: bindings: input

From: Dmitry Torokhov <dmitry.torokhov@gmail•com>
To: fengping yu <fengping.yu@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>, Jacky Bai <ping.bai@nxp•com>,
	wsd_upstream@mediatek•com, Stefan Agner <stefan@agner•cn>,
	Catalin Marinas <catalin.marinas@arm•com>,
	Marco Felsch <m.felsch@pengutronix•de>,
	Leonard Crestez <leonard.crestez@nxp•com>,
	Will Deacon <will@kernel•org>, Anson Huang <Anson.Huang@nxp•com>,
	YueHaibing <yuehaibing@huawei•com>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro•org>,
	linux-input@vger•kernel.org, Thierry Reding <treding@nvidia•com>,
	Valentin Schneider <valentin.schneider@arm•com>,
	devicetree@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
	Maxime Ripard <mripard@kernel•org>,
	Mark Brown <broonie@kernel•org>,
	linux-mediatek@lists•infradead.org,
	Matthias Brugger <matthias.bgg@gmail•com>,
	Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
	linux-arm-kernel@lists•infradead.org,
	Aisheng Dong <aisheng.dong@nxp•com>,
	linux-kernel@vger•kernel.org, Dinh Nguyen <dinguyen@kernel•org>,
	Rob Herring <robh+dt@kernel•org>, Olof Johansson <olof@lixom•net>,
	Shawn Guo <shawnguo@kernel•org>
Subject: Re: [PATCH V2 1/2] Documentation: devicetree: bindings: input
Date: Thu, 9 Jan 2020 17:16:14 -0800	[thread overview]
Message-ID: <20200110011614.GQ8314@dtor-ws> (raw)
In-Reply-To: <20200108062923.14684-2-fengping.yu@mediatek.com>

Hi Fengping,

On Wed, Jan 08, 2020 at 02:29:22PM +0800, fengping yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek•com>
> 
> Add mtk keypad device tree documentation.
> 
> Change-Id: I415b76ee980784992763c768829b2dda76699dea
> Signed-off-by: fengping.yu <fengping.yu@mediatek•com>
> ---
>  .../devicetree/bindings/input/mtk-kpd.txt     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/mtk-kpd.txt b/Documentation/devicetree/bindings/input/mtk-kpd.txt
> new file mode 100644
> index 000000000000..2af81e696159
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/mtk-kpd.txt
> @@ -0,0 +1,45 @@
> +* Mediatek's Keypad Controller device tree binding
> +
> +Mediatek's Keypad controller is used to interface a SoC with a matrix-type
> +keypad device. The keypad controller supports multiple row and column lines.
> +A key can be placed at each intersection of a unique row and a unique column.
> +The keypad controller can sense a key-press and key-release and report the
> +event using a interrupt to the cpu.
> +
> +Required properties:
> +- compatible should contain:
> +	* "mediatek,mt6779-keypad" for MT6779 keypad
> +	* "mediatek,kp" for common keypad
> +
> +- reg: The base address of the Keypad register bank.
> +
> +- interrupts: A single interrupt specifier.
> +
> +- mediatek,key-debounce-ms: Debounce interval in milliseconds, maximum value
> +  is 256ms
> +
> +- mediatek,hw-map-num: Number of entries of keycode in mediatek,hw-init-map
> +
> +- mediatek,hw-init-map: An array of packed 1-cell entries containing the
> +  equivalent of hw-map-num linux key-code. Each cell is Linux keymap of
> +  corresponding row/col, arrange like this:
> +
> +  row0col0, row0col1, row0col2,...row0col8,
> +  row1col0, row1col1, row1col2,...row1col8,
> +  ...
> +  row7col0, row7col1, row7col2,...row7col8.

Please use standard "linux,keymap" property as defined in
Documentation/devicetree/bindings/input/matrix-keymap.txt. You can use
API from drivers/input/matrix-keymap.c to handle the property.

Thanks.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel