From: Quentin Perret <qperret@google•com>
To: Lukasz Luba <lukasz.luba@arm•com>
Cc: nm@ti•com, juri.lelli@redhat•com, peterz@infradead•org,
viresh.kumar@linaro•org, liviu.dudau@arm•com,
dri-devel@lists•freedesktop.org, bjorn.andersson@linaro•org,
bsegall@google•com, alyssa.rosenzweig@collabora•com,
festevam@gmail•com, Morten.Rasmussen@arm•com, robh@kernel•org,
amit.kucheria@verdurent•com, lorenzo.pieralisi@arm•com,
khilman@kernel•org, agross@kernel•org, daniel.lezcano@linaro•org,
steven.price@arm•com, cw00.choi@samsung•com, mingo@redhat•com,
linux-imx@nxp•com, rui.zhang@intel•com, mgorman@suse•de,
orjan.eide@arm•com, daniel@ffwll•ch, linux-pm@vger•kernel.org,
linux-arm-msm@vger•kernel.org, s.hauer@pengutronix•de,
rostedt@goodmis•org, linux-mediatek@lists•infradead.org,
matthias.bgg@gmail•com, linux-omap@vger•kernel.org,
Dietmar.Eggemann@arm•com, linux-arm-kernel@lists•infradead.org,
airlied@linux•ie, javi.merino@arm•com,
tomeu.vizoso@collabora•com, sboyd@kernel•org,
rdunlap@infradead•org, rjw@rjwysocki•net,
linux-kernel@vger•kernel.org, b.zolnierkie@samsung•com,
kernel@pengutronix•de, sudeep.holla@arm•com,
patrick.bellasi@matbug•net, shawnguo@kernel•org
Subject: Re: [PATCH v4 1/4] PM / EM: add devices to Energy Model
Date: Fri, 13 Mar 2020 17:15:21 +0000 [thread overview]
Message-ID: <20200313171521.GA236432@google.com> (raw)
In-Reply-To: <bd1233f4-6e8b-23d1-e5aa-7c904fbd1bb3@arm.com>
On Friday 13 Mar 2020 at 16:49:24 (+0000), Lukasz Luba wrote:
<snip>
> Well if someone would add EM to its platform and call this in
> hotplug, which is used as cooling method, will see a lot of warnings.
Right, but I guess I was arguing that calling this for CPUs, even on
hotplug, is kinda wrong.
> I would rather avoid stressing people with this kind of warnings.
> This is under control and nothing really happens even when they
> do hotplug very often, like LTP stress tests.
>
> I agree to add a print there but warning for me is when something
> is not OK and should be investigated.
> I would prefer dev_dbg_once() to print thet the EM is not going to be
> removed. This will also not pollute dmesg in many logs.
Fair enough, a WARN is maybe a bit over the top. A debug message
should work.
<snip>
> So these small changes will be present in v5. I have to wait a few
> days because there is one change to devfreq_cooling.c queuing and I will
> send v5 with updated patch 3/4 rebased on top.
Sounds good, thanks.
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-13 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 13:41 [PATCH v4 0/4] Add support for devices in the Energy Model Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 1/4] PM / EM: add devices to " Lukasz Luba
2020-03-13 10:04 ` Quentin Perret
2020-03-13 10:05 ` Quentin Perret
2020-03-13 16:49 ` Lukasz Luba
2020-03-13 17:15 ` Quentin Perret [this message]
2020-03-09 13:41 ` [PATCH v4 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Lukasz Luba
2020-03-13 10:15 ` Quentin Perret
2020-03-13 17:11 ` Lukasz Luba
2020-03-13 17:16 ` Quentin Perret
2020-03-09 13:41 ` [PATCH v4 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model Lukasz Luba
2020-03-09 13:41 ` [PATCH v4 4/4] drm/panfrost: Register devfreq cooling and attempt to add " Lukasz Luba
2020-03-09 14:15 ` Steven Price
2020-03-13 16:51 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313171521.GA236432@google.com \
--to=qperret@google$(echo .)com \
--cc=Dietmar.Eggemann@arm$(echo .)com \
--cc=Morten.Rasmussen@arm$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=alyssa.rosenzweig@collabora$(echo .)com \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=bsegall@google$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=festevam@gmail$(echo .)com \
--cc=javi.merino@arm$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=liviu.dudau@arm$(echo .)com \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=lukasz.luba@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=nm@ti$(echo .)com \
--cc=orjan.eide@arm$(echo .)com \
--cc=patrick.bellasi@matbug$(echo .)net \
--cc=peterz@infradead$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sboyd@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=steven.price@arm$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=tomeu.vizoso@collabora$(echo .)com \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox