* Re: linux-next: build warning after merge of the aspeed tree
[not found] ` <CACPK8Xd4651vtBTbBoGk0G7daunmF2CCOsDZ-ceto7Yu6A5z5g@mail.gmail.com>
@ 2020-05-22 0:16 ` Stephen Rothwell
2020-05-22 8:15 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-05-22 0:16 UTC (permalink / raw)
To: Olof Johansson, Arnd Bergmann, ARM
Cc: devicetree, Arnd Bergmann, Andrew Jeffery,
Linux Kernel Mailing List, Rob Herring, Vijay Khemka,
Linux Next Mailing List, Joel Stanley, Manikandan Elumalai,
Devicetree Compiler
[-- Attachment #1.1: Type: text/plain, Size: 3368 bytes --]
Hi all,
On Wed, 20 May 2020 07:56:36 +0000 Joel Stanley <joel@jms•id.au> wrote:
>
> On Mon, 11 May 2020 at 15:19, Rob Herring <robh+dt@kernel•org> wrote:
> >
> > On Fri, May 8, 2020 at 1:40 AM Joel Stanley <joel@jms•id.au> wrote:
> > >
> > > On Wed, 6 May 2020 at 23:13, Joel Stanley <joel@jms•id.au> wrote:
> > > >
> > > > Hi Rob,
> > > >
> > > > On Wed, 6 May 2020 at 23:10, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > > > >
> > > > > After merging the aspeed tree, today's linux-next build (arm
> > > > > multi_v7_defconfig) produced this warning:
> > > >
> > > > Thanks Stephen.
> > > >
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10: I2C bus unit address format error, expected "40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg: I2C address must be less than 10-bits, got "0x40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:137.11-141.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10: I2C bus unit address format error, expected "40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:139.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10:reg: I2C address must be less than 10-bits, got "0x40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:148.11-152.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10: I2C bus unit address format error, expected "40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:150.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10:reg: I2C address must be less than 10-bits, got "0x40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:159.11-163.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10: I2C bus unit address format error, expected "40000010"
> > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:161.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10:reg: I2C address must be less than 10-bits, got "0x40000010"
> > > >
> > > > These are IPMB nodes with the SLAVE_ADDRESS bit set:
> > > >
> > > > +&i2c5 {
> > > > + //Host3 IPMB bus
> > > > + status = "okay";
> > > > + multi-master;
> > > > + ipmb5@10 {
> > > > + compatible = "ipmb-dev";
> > > > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > > > + i2c-protocol;
> > > > + };
> > > >
> > > > This is a correct entry, so dtc should not warn about it.
> > >
> > > I sent a patch for dtc here:
> > > https://lore.kernel.org/lkml/20200508063904.60162-1-joel@jms.id.au/
> >
> > Patches for dtc need to be against upstream dtc. There's already a
> > similar patch posted for it which I commented on and never saw a
> > respin.
>
> Can I suggest some instructions in scsripts/dtc explaining that you
> don't take patches in the kernel tree for this code?
>
> I've sent the patch so it applies to the dtc tree. It would be good to
> see that change propagate over to -next as others have reported this
> warning.
These warnings now appear in the arm-soc tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the aspeed tree
2020-05-22 0:16 ` linux-next: build warning after merge of the aspeed tree Stephen Rothwell
@ 2020-05-22 8:15 ` Arnd Bergmann
2020-05-28 6:09 ` Joel Stanley
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2020-05-22 8:15 UTC (permalink / raw)
To: Stephen Rothwell
Cc: ARM, devicetree, Andrew Jeffery, Linux Kernel Mailing List,
Vijay Khemka, Linux Next Mailing List, Rob Herring, Joel Stanley,
Olof Johansson, Manikandan Elumalai, Devicetree Compiler,
David Gibson
On Fri, May 22, 2020 at 2:16 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> On Wed, 20 May 2020 07:56:36 +0000 Joel Stanley <joel@jms•id.au> wrote:
> > On Mon, 11 May 2020 at 15:19, Rob Herring <robh+dt@kernel•org> wrote:
> > > On Wed, 6 May 2020 at 23:13, Joel Stanley <joel@jms•id.au> wrote:
> > > > > These are IPMB nodes with the SLAVE_ADDRESS bit set:
> > > > >
> > > > > +&i2c5 {
> > > > > + //Host3 IPMB bus
> > > > > + status = "okay";
> > > > > + multi-master;
> > > > > + ipmb5@10 {
> > > > > + compatible = "ipmb-dev";
> > > > > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > > > > + i2c-protocol;
> > > > > + };
> > > > >
> > > > > This is a correct entry, so dtc should not warn about it.
> > > >
> > > > I sent a patch for dtc here:
> > > > https://lore.kernel.org/lkml/20200508063904.60162-1-joel@jms.id.au/
> > >
> > > Patches for dtc need to be against upstream dtc. There's already a
> > > similar patch posted for it which I commented on and never saw a
> > > respin.
> >
> > Can I suggest some instructions in scsripts/dtc explaining that you
> > don't take patches in the kernel tree for this code?
> >
> > I've sent the patch so it applies to the dtc tree. It would be good to
> > see that change propagate over to -next as others have reported this
> > warning.
>
> These warnings now appear in the arm-soc tree.
Right, I also saw them earlier.
Joel, have you sent your patch to David Gibson for integration into
upstream dtc?
I don't know who sent the other patch, but as long as one of them
gets merged, I'd hope we can pull that into kernel as well.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the aspeed tree
2020-05-22 8:15 ` Arnd Bergmann
@ 2020-05-28 6:09 ` Joel Stanley
2020-05-28 7:21 ` Joel Stanley
0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2020-05-28 6:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stephen Rothwell, devicetree, Andrew Jeffery,
Linux Kernel Mailing List, Vijay Khemka, Linux Next Mailing List,
Rob Herring, ARM, Olof Johansson, Manikandan Elumalai,
Devicetree Compiler, David Gibson
On Fri, 22 May 2020 at 08:16, Arnd Bergmann <arnd@arndb•de> wrote:
>
> On Fri, May 22, 2020 at 2:16 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > On Wed, 20 May 2020 07:56:36 +0000 Joel Stanley <joel@jms•id.au> wrote:
> > > I've sent the patch so it applies to the dtc tree. It would be good to
> > > see that change propagate over to -next as others have reported this
> > > warning.
> >
> > These warnings now appear in the arm-soc tree.
>
> Right, I also saw them earlier.
>
> Joel, have you sent your patch to David Gibson for integration into
> upstream dtc?
> I don't know who sent the other patch, but as long as one of them
> gets merged, I'd hope we can pull that into kernel as well.
David asked for some extra features (and a typo fix) before he would
merge it. I'll take a look at that now.
The patch is 20200520075134.1048589-1-joel@jms•id.au on
devicetree-compiler@vger•kernel.org, which doesn't appear to be
archived on lore.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the aspeed tree
2020-05-28 6:09 ` Joel Stanley
@ 2020-05-28 7:21 ` Joel Stanley
0 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2020-05-28 7:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stephen Rothwell, devicetree, Andrew Jeffery,
Linux Kernel Mailing List, Vijay Khemka, Linux Next Mailing List,
Rob Herring, ARM, Olof Johansson, Manikandan Elumalai,
Devicetree Compiler, David Gibson
On Thu, 28 May 2020 at 06:09, Joel Stanley <joel@jms•id.au> wrote:
>
> On Fri, 22 May 2020 at 08:16, Arnd Bergmann <arnd@arndb•de> wrote:
> >
> > On Fri, May 22, 2020 at 2:16 AM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > > On Wed, 20 May 2020 07:56:36 +0000 Joel Stanley <joel@jms•id.au> wrote:
> > > > I've sent the patch so it applies to the dtc tree. It would be good to
> > > > see that change propagate over to -next as others have reported this
> > > > warning.
> > >
> > > These warnings now appear in the arm-soc tree.
> >
> > Right, I also saw them earlier.
> >
> > Joel, have you sent your patch to David Gibson for integration into
> > upstream dtc?
> > I don't know who sent the other patch, but as long as one of them
> > gets merged, I'd hope we can pull that into kernel as well.
>
> David asked for some extra features (and a typo fix) before he would
> merge it. I'll take a look at that now.
Here we go:
https://lore.kernel.org/lkml/20200528072037.1402346-1-joel@jms.id.au/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 7:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200507091008.1bd38185@canb.auug.org.au>
[not found] ` <CACPK8XfOJqj=E4JwQsZWvAsp7cv=bjqj2twZk0=MR+ZJQP1nqQ@mail.gmail.com>
[not found] ` <CACPK8XcUydETZvJEkWPvLnLXatAg3D-MfA1yeDzE0epc-hisJQ@mail.gmail.com>
[not found] ` <CAL_JsqJWXH4JMZgRQa9r_aPLW6Muz6BRtf_NmeqJv21Aefji1A@mail.gmail.com>
[not found] ` <CACPK8Xd4651vtBTbBoGk0G7daunmF2CCOsDZ-ceto7Yu6A5z5g@mail.gmail.com>
2020-05-22 0:16 ` linux-next: build warning after merge of the aspeed tree Stephen Rothwell
2020-05-22 8:15 ` Arnd Bergmann
2020-05-28 6:09 ` Joel Stanley
2020-05-28 7:21 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox