From: Krzysztof Kozlowski <krzk@kernel•org>
To: Chanwoo Choi <cw00.choi@samsung•com>,
Krzysztof Kozlowski <krzk@kernel•org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Michael Turquette <mturquette@baylibre•com>,
Stephen Boyd <sboyd@kernel•org>, Rob Herring <robh+dt@kernel•org>,
Lee Jones <lee.jones@linaro•org>,
Sebastian Reichel <sre@kernel•org>,
Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>, Andy Gross <agross@kernel•org>,
Bjorn Andersson <bjorn.andersson@linaro•org>,
Alessandro Zummo <a.zummo@towertech•it>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
devicetree@vger•kernel.org, linux-pm@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org, linux-arm-msm@vger•kernel.org,
linux-rtc@vger•kernel.org
Cc: Angus Ainslie <angus@akkea•ca>,
Hans de Goede <hdegoede@redhat•com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri•sm>,
Iskren Chernev <iskren.chernev@gmail•com>,
Matheus Castello <matheus@castello•eng.br>
Subject: [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: correct fuel gauge interrupt trigger level
Date: Thu, 10 Dec 2020 22:25:28 +0100 [thread overview]
Message-ID: <20201210212534.216197-12-krzk@kernel.org> (raw)
In-Reply-To: <20201210212534.216197-1-krzk@kernel.org>
The Maxim fuel gauge datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU. The falling edge
interrupt will mostly work but it's not correct.
Fixes: da8d46992e67 ("ARM: dts: qcom: msm8974-klte: Add fuel gauge")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
---
arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
index 97352de91314..64a3fdb79539 100644
--- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
@@ -691,7 +691,7 @@ fuelgauge@36 {
maxim,rcomp = /bits/ 8 <0x56>;
interrupt-parent = <&pma8084_gpios>;
- interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&fuelgauge_pin>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-10 21:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 21:25 [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 02/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family Krzysztof Kozlowski
2020-12-29 15:43 ` Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 04/18] ARM: dts: exynos: correct MUIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 05/18] ARM: dts: exynos: correct PMIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 06/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 08/18] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 09/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Snow Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 10/18] ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level Krzysztof Kozlowski
2020-12-11 15:29 ` Iskren Chernev
2020-12-10 21:25 ` Krzysztof Kozlowski [this message]
2020-12-11 15:25 ` [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: " Iskren Chernev
2020-12-10 21:25 ` [RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2020-12-21 18:45 ` Rob Herring
2020-12-10 21:25 ` [RFC 14/18] rtc: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 15/18] mfd: max77693: " Krzysztof Kozlowski
2020-12-21 18:46 ` Rob Herring
2020-12-10 21:25 ` [RFC 16/18] power: supply: max17042: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 17/18] mfd: max14577: " Krzysztof Kozlowski
2020-12-21 18:47 ` Rob Herring
2020-12-10 21:25 ` [RFC 18/18] power: supply: max17040: " Krzysztof Kozlowski
2020-12-11 7:47 ` Krzysztof Kozlowski
2020-12-11 15:44 ` Iskren Chernev
2020-12-11 15:51 ` Krzysztof Kozlowski
2021-03-03 18:19 ` [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210212534.216197-12-krzk@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=a.zummo@towertech$(echo .)it \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=angus@akkea$(echo .)ca \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=cw00.choi@samsung$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=hdegoede@redhat$(echo .)com \
--cc=iskren.chernev@gmail$(echo .)com \
--cc=lee.jones@linaro$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=matheus@castello$(echo .)eng.br \
--cc=mturquette@baylibre$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sebastian.krzyszkowiak@puri$(echo .)sm \
--cc=sre@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox