From: Rob Herring <robh@kernel•org>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin•com>,
Michael Turquette <mturquette@baylibre•com>,
Angus Ainslie <angus@akkea•ca>,
Bjorn Andersson <bjorn.andersson@linaro•org>,
Iskren Chernev <iskren.chernev@gmail•com>,
Lee Jones <lee.jones@linaro•org>,
linux-clk@vger•kernel.org, linux-rtc@vger•kernel.org,
linux-samsung-soc@vger•kernel.org, linux-pm@vger•kernel.org,
Chanwoo Choi <cw00.choi@samsung•com>,
Andy Gross <agross@kernel•org>,
devicetree@vger•kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
linux-arm-msm@vger•kernel.org,
Hans de Goede <hdegoede@redhat•com>,
Mark Brown <broonie@kernel•org>,
Matheus Castello <matheus@castello•eng.br>,
linux-arm-kernel@lists•infradead.org,
Alessandro Zummo <a.zummo@towertech•it>,
Stephen Boyd <sboyd@kernel•org>,
Liam Girdwood <lgirdwood@gmail•com>,
linux-kernel@vger•kernel.org, Rob Herring <robh+dt@kernel•org>,
Sebastian Reichel <sre@kernel•org>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri•sm>
Subject: Re: [RFC 15/18] mfd: max77693: Do not enforce (incorrect) interrupt trigger type
Date: Mon, 21 Dec 2020 11:46:12 -0700 [thread overview]
Message-ID: <20201221184612.GA342913@robh.at.kernel.org> (raw)
In-Reply-To: <20201210212534.216197-15-krzk@kernel.org>
On Thu, 10 Dec 2020 22:25:31 +0100, Krzysztof Kozlowski wrote:
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 77693 datasheet describes the interrupt line as active low
> with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races. With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
>
> ---
>
> This patch should wait till DTS changes are merged, as it relies on
> proper Devicetree.
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 2 +-
> drivers/mfd/max77693.c | 12 ++++--------
> 2 files changed, 5 insertions(+), 9 deletions(-)
>
Acked-by: Rob Herring <robh@kernel•org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-21 18:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 21:25 [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 02/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family Krzysztof Kozlowski
2020-12-29 15:43 ` Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 04/18] ARM: dts: exynos: correct MUIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 05/18] ARM: dts: exynos: correct PMIC " Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 06/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 08/18] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250 Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 09/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Snow Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 10/18] ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family Krzysztof Kozlowski
2020-12-10 21:25 ` [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level Krzysztof Kozlowski
2020-12-11 15:29 ` Iskren Chernev
2020-12-10 21:25 ` [PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: " Krzysztof Kozlowski
2020-12-11 15:25 ` Iskren Chernev
2020-12-10 21:25 ` [RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2020-12-21 18:45 ` Rob Herring
2020-12-10 21:25 ` [RFC 14/18] rtc: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 15/18] mfd: max77693: " Krzysztof Kozlowski
2020-12-21 18:46 ` Rob Herring [this message]
2020-12-10 21:25 ` [RFC 16/18] power: supply: max17042: " Krzysztof Kozlowski
2020-12-10 21:25 ` [RFC 17/18] mfd: max14577: " Krzysztof Kozlowski
2020-12-21 18:47 ` Rob Herring
2020-12-10 21:25 ` [RFC 18/18] power: supply: max17040: " Krzysztof Kozlowski
2020-12-11 7:47 ` Krzysztof Kozlowski
2020-12-11 15:44 ` Iskren Chernev
2020-12-11 15:51 ` Krzysztof Kozlowski
2021-03-03 18:19 ` [PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221184612.GA342913@robh.at.kernel.org \
--to=robh@kernel$(echo .)org \
--cc=a.zummo@towertech$(echo .)it \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=angus@akkea$(echo .)ca \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=cw00.choi@samsung$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=hdegoede@redhat$(echo .)com \
--cc=iskren.chernev@gmail$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=lee.jones@linaro$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=matheus@castello$(echo .)eng.br \
--cc=mturquette@baylibre$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sebastian.krzyszkowiak@puri$(echo .)sm \
--cc=sre@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox