Re: [PATCH 02/25] staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count

From: Jonathan Cameron <Jonathan.Cameron@Huawei•com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel•org>
Cc: <linuxarm@huawei•com>, <mauro.chehab@huawei•com>,
	Fabio Estevam <festevam@gmail•com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	"Mauro Carvalho Chehab" <mchehab@kernel•org>,
	NXP Linux Team <linux-imx@nxp•com>,
	Pengutronix Kernel Team <kernel@pengutronix•de>,
	Philipp Zabel <p.zabel@pengutronix•de>,
	Rui Miguel Silva <rmfrfs@gmail•com>,
	Sascha Hauer <s.hauer@pengutronix•de>,
	Shawn Guo <shawnguo@kernel•org>,
	Steve Longerbeam <slongerbeam@gmail•com>,
	<linux-arm-kernel@lists•infradead.org>,
	<linux-kernel@vger•kernel.org>, <linux-media@vger•kernel.org>,
	<linux-staging@lists•linux.dev>
Subject: Re: [PATCH 02/25] staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count
Date: Wed, 5 May 2021 12:06:52 +0100	[thread overview]
Message-ID: <20210505120652.00001236@Huawei.com> (raw)
In-Reply-To: <793a5806a63b6313606fd1c344b9eec41e61a440.1620207353.git.mchehab+huawei@kernel.org>

On Wed, 5 May 2021 11:41:52 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel•org> wrote:

> The pm_runtime_get_sync() internally increments the
> dev->power.usage_count without decrementing it, even on errors.
> Replace it by the new pm_runtime_resume_and_get(), introduced by:
> commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> in order to properly decrement the usage counter, avoiding
> a potential PM usage counter leak.
> 
> Acked-by: Rui Miguel Silva <rmfrfs@gmail•com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel•org>

Not a fix as far as I can see, just a cleanup - so perhaps not this set?

Jonathan

> ---
>  drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 025fdc488bd6..1dc680d94a46 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -695,11 +695,10 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable)
>  
>  		mipi_csis_clear_counters(state);
>  
> -		ret = pm_runtime_get_sync(&state->pdev->dev);
> -		if (ret < 0) {
> -			pm_runtime_put_noidle(&state->pdev->dev);
> +		ret = pm_runtime_resume_and_get(&state->pdev->dev);
> +		if (ret < 0)
>  			return ret;
> -		}
> +
>  		ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
>  		if (ret < 0 && ret != -ENOIOCTLCMD)
>  			goto done;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel