From: Jonathan Cameron <Jonathan.Cameron@Huawei•com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel•org>
Cc: <linuxarm@huawei•com>, <mauro.chehab@huawei•com>,
Ezequiel Garcia <ezequiel@collabora•com>,
Hans Verkuil <hverkuil-cisco@xs4all•nl>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical•com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Sylwester Nawrocki <s.nawrocki@samsung•com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-kernel@vger•kernel.org>, <linux-media@vger•kernel.org>,
<linux-samsung-soc@vger•kernel.org>
Subject: Re: [PATCH 24/25] media: exynos-gsc: fix pm_runtime_get_sync() usage count
Date: Wed, 5 May 2021 13:34:50 +0100 [thread overview]
Message-ID: <20210505133450.00001fda@Huawei.com> (raw)
In-Reply-To: <d73f24e33fb9b1cc0ff968bec833184c6510b9ec.1620207353.git.mchehab+huawei@kernel.org>
On Wed, 5 May 2021 11:42:14 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel•org> wrote:
> The pm_runtime_get_sync() internally increments the
> dev->power.usage_count without decrementing it, even on errors.
> Replace it by the new pm_runtime_resume_and_get(), introduced by:
> commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> in order to properly decrement the usage counter, avoiding
> a potential PM usage counter leak.
>
> As a bonus, as pm_runtime_get_sync() always return 0 on
> success, the logic can be simplified.
>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel•org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei•com>
> ---
> drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c
> index 27a3c92c73bc..f1cf847d1cc2 100644
> --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c
> +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c
> @@ -56,10 +56,8 @@ static void __gsc_m2m_job_abort(struct gsc_ctx *ctx)
> static int gsc_m2m_start_streaming(struct vb2_queue *q, unsigned int count)
> {
> struct gsc_ctx *ctx = q->drv_priv;
> - int ret;
>
> - ret = pm_runtime_get_sync(&ctx->gsc_dev->pdev->dev);
> - return ret > 0 ? 0 : ret;
> + return pm_runtime_resume_and_get(&ctx->gsc_dev->pdev->dev);
> }
>
> static void __gsc_m2m_cleanup_queue(struct gsc_ctx *ctx)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-05 12:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 9:41 [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
2021-05-05 9:41 ` [PATCH 02/25] staging: media: imx7-mipi-csis: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-05-05 11:06 ` Jonathan Cameron
2021-05-05 11:17 ` Mauro Carvalho Chehab
2021-05-05 13:56 ` Rui Miguel Silva
2021-05-05 14:23 ` Mauro Carvalho Chehab
2021-05-05 9:41 ` [PATCH 07/25] media: exynos-gsc: don't resume at remove time Mauro Carvalho Chehab
2021-05-05 12:27 ` Jonathan Cameron
2021-05-05 9:41 ` [PATCH 08/25] media: atmel: properly get pm_runtime Mauro Carvalho Chehab
2021-05-05 12:08 ` Jonathan Cameron
2021-06-10 9:04 ` Eugen.Hristev
2021-06-10 9:38 ` Mauro Carvalho Chehab
2021-06-10 12:00 ` Eugen.Hristev
2021-06-16 8:03 ` Mauro Carvalho Chehab
2021-09-06 8:03 ` Mauro Carvalho Chehab
2021-09-06 8:13 ` Eugen.Hristev
2021-09-13 10:26 ` Eugen.Hristev
2021-05-05 9:42 ` [PATCH 11/25] media: mdk-mdp: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-05-05 9:42 ` [PATCH 18/25] media: mtk-vcodec: fix PM runtime get logic Mauro Carvalho Chehab
2021-05-05 12:32 ` Jonathan Cameron
2021-05-05 9:42 ` [PATCH 19/25] media: s5p-jpeg: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-05-05 12:33 ` Jonathan Cameron
2021-05-05 9:42 ` [PATCH 21/25] media: sunxi: " Mauro Carvalho Chehab
2021-05-05 9:42 ` [PATCH 23/25] media: exynos4-is: " Mauro Carvalho Chehab
2021-05-05 12:20 ` Jonathan Cameron
2021-05-05 9:42 ` [PATCH 24/25] media: exynos-gsc: " Mauro Carvalho Chehab
2021-05-05 12:34 ` Jonathan Cameron [this message]
2021-05-06 15:11 ` [PATCH 00/25] Fix some PM runtime issues at the media subsystem Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505133450.00001fda@Huawei.com \
--to=jonathan.cameron@huawei$(echo .)com \
--cc=ezequiel@collabora$(echo .)com \
--cc=hverkuil-cisco@xs4all$(echo .)nl \
--cc=krzysztof.kozlowski@canonical$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=mauro.chehab@huawei$(echo .)com \
--cc=mchehab+huawei@kernel$(echo .)org \
--cc=mchehab@kernel$(echo .)org \
--cc=s.nawrocki@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox