From: Greg KH <gregkh@linuxfoundation•org>
To: Stepan Ionichev <sozdayvek@gmail•com>
Cc: Frank.Li@nxp•com, s.hauer@pengutronix•de, kernel@pengutronix•de,
festevam@gmail•com, shawnguo@kernel•org, hcazarim@yahoo•com,
imx@lists•linux.dev, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] firmware: imx: scu-irq: accumulate wakeup sources via sysfs_emit_at()
Date: Sat, 16 May 2026 09:15:54 +0200 [thread overview]
Message-ID: <2026051633-doorstep-sequence-6782@gregkh> (raw)
In-Reply-To: <20260515175002.34853-1-sozdayvek@gmail.com>
On Fri, May 15, 2026 at 10:50:01PM +0500, Stepan Ionichev wrote:
> wakeup_source_show() walks all IMX_SC_IRQ_NUM_GROUP groups and, for
> every group with a wakeup_src set, writes a line into the sysfs
> output buffer:
>
> for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) {
> if (!scu_irq_wakeup[i].wakeup_src)
> continue;
>
> if (scu_irq_wakeup[i].valid)
> sprintf(buf, "Wakeup source group = %d, ...", ...);
> else
> sprintf(buf, "Spurious SCU wakeup, group = %d, ...", ...);
This is a horrible sysfs file, and breaks all the rules. Why not just
delete it and use the proper api for it instead?
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-16 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 17:50 [PATCH] firmware: imx: scu-irq: accumulate wakeup sources via sysfs_emit_at() Stepan Ionichev
2026-05-16 7:15 ` Greg KH [this message]
2026-05-16 9:07 ` Stepan Ionichev
2026-05-16 9:20 ` Greg KH
2026-05-18 1:29 ` Peng Fan
2026-05-18 9:39 ` [PATCH v2] firmware: imx: scu-irq: drop wakeup_src sysfs file, log via dev_dbg() Stepan Ionichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051633-doorstep-sequence-6782@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Frank.Li@nxp$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=hcazarim@yahoo$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=sozdayvek@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox