From: Peng Fan <peng.fan@oss•nxp.com>
To: Stepan Ionichev <sozdayvek@gmail•com>
Cc: gregkh@linuxfoundation•org, Frank.Li@nxp•com,
s.hauer@pengutronix•de, kernel@pengutronix•de,
festevam@gmail•com, shawnguo@kernel•org, hcazarim@yahoo•com,
imx@lists•linux.dev, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] firmware: imx: scu-irq: accumulate wakeup sources via sysfs_emit_at()
Date: Mon, 18 May 2026 09:29:38 +0800 [thread overview]
Message-ID: <agprgizn9lF7utJ5@shlinux89> (raw)
In-Reply-To: <20260516090726.38362-1-sozdayvek@gmail.com>
Hi Stepan,
On Sat, May 16, 2026 at 02:07:26PM +0500, Stepan Ionichev wrote:
>On Sat, May 16, 2026 at 09:15:54AM +0200, Greg Kroah-Hartman wrote:
>> This is a horrible sysfs file, and breaks all the rules. Why not just
>> delete it and use the proper api for it instead?
>
>Yeah, fair. The sprintf change just papers over the real issue, which
>is the interface itself.
>
>Quick check: no Documentation/ABI/ entry, github code search returns
>nothing outside the kernel tree itself
>(https://github.com/search?q=scu_wakeup_irqs&type=code), and
>codesearch.debian.net also shows zero hits. So removing the attribute
>looks doable.
>
>Frank, Sascha -- any out-of-tree readers of
>/sys/firmware/scu_wakeup_irqs/wakeup_src I should worry about? If
>not, I'll send v2 that drops the attribute and logs the wakeup source
I think it is safe to drop, thanks for working on this.
Thanks
Peng
>via dev_info() instead.
>
>Stepan
next prev parent reply other threads:[~2026-05-18 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 17:50 [PATCH] firmware: imx: scu-irq: accumulate wakeup sources via sysfs_emit_at() Stepan Ionichev
2026-05-16 7:15 ` Greg KH
2026-05-16 9:07 ` Stepan Ionichev
2026-05-16 9:20 ` Greg KH
2026-05-18 1:29 ` Peng Fan [this message]
2026-05-18 9:39 ` [PATCH v2] firmware: imx: scu-irq: drop wakeup_src sysfs file, log via dev_dbg() Stepan Ionichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agprgizn9lF7utJ5@shlinux89 \
--to=peng.fan@oss$(echo .)nxp.com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hcazarim@yahoo$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=sozdayvek@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox