From: Yuho Choi <dbgh9129@gmail•com>
To: Dinh Nguyen <dinguyen@kernel•org>, Russell King <linux@armlinux•org.uk>
Cc: linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, Yuho Choi <dbgh9129@gmail•com>
Subject: [PATCH v1] ARM: socfpga: Fix OF node refcount leak in SMP setup
Date: Sun, 24 May 2026 22:31:01 -0400 [thread overview]
Message-ID: <20260525023101.1329892-1-dbgh9129@gmail.com> (raw)
socfpga_smp_prepare_cpus() looks up the Cortex-A9 SCU node with
of_find_compatible_node(), which returns a node reference that must be
released with of_node_put().
The function maps the SCU registers and then returns without dropping
that reference, leaking the node on both the success path and the
of_iomap() failure path.
Drop the reference once the mapping attempt is complete. The returned
MMIO mapping does not depend on keeping the device node reference held.
Fixes: 122694a0c712 ("ARM: socfpga: use of_iomap to map the SCU")
Signed-off-by: Yuho Choi <dbgh9129@gmail•com>
---
arch/arm/mach-socfpga/platsmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
index 201191cf68f3..349e6c54518e 100644
--- a/arch/arm/mach-socfpga/platsmp.c
+++ b/arch/arm/mach-socfpga/platsmp.c
@@ -78,6 +78,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int max_cpus)
}
socfpga_scu_base_addr = of_iomap(np, 0);
+ of_node_put(np);
if (!socfpga_scu_base_addr)
return;
scu_enable(socfpga_scu_base_addr);
--
2.43.0
next reply other threads:[~2026-05-25 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 2:31 Yuho Choi [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-25 2:47 [PATCH v1] ARM: socfpga: Fix OF node refcount leak in SMP setup Yuho Choi
2026-05-26 14:54 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525023101.1329892-1-dbgh9129@gmail.com \
--to=dbgh9129@gmail$(echo .)com \
--cc=dinguyen@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox