From: Dinh Nguyen <dinguyen@kernel•org>
To: Yuho Choi <dbgh9129@gmail•com>, Russell King <linux@armlinux•org.uk>
Cc: linux-arm-kernel@lists•infradead.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v1] ARM: socfpga: Fix OF node refcount leak in SMP setup
Date: Tue, 26 May 2026 09:54:47 -0500 [thread overview]
Message-ID: <6e123037-e677-4f6a-95cf-a065c646a602@kernel.org> (raw)
In-Reply-To: <20260525024709.1336252-1-dbgh9129@gmail.com>
Hi Yuho,
On 5/24/26 21:47, Yuho Choi wrote:
> socfpga_smp_prepare_cpus() looks up the Cortex-A9 SCU node with
> of_find_compatible_node(), which returns a node reference that must be
> released with of_node_put().
>
> The function maps the SCU registers and then returns without dropping
> that reference, leaking the node on both the success path and the
> of_iomap() failure path.
>
> Drop the reference once the mapping attempt is complete. The returned
> MMIO mapping does not depend on keeping the device node reference held.
>
> Fixes: 122694a0c712 ("ARM: socfpga: use of_iomap to map the SCU")
> Signed-off-by: Yuho Choi <dbgh9129@gmail•com>
I'll add "Cc: stable@vger•kernel.org" here, but please remember to add
this for future patches that have the Fixes tag.
Thanks,
Dinh
next prev parent reply other threads:[~2026-05-26 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 2:47 [PATCH v1] ARM: socfpga: Fix OF node refcount leak in SMP setup Yuho Choi
2026-05-26 14:54 ` Dinh Nguyen [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-25 2:31 Yuho Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e123037-e677-4f6a-95cf-a065c646a602@kernel.org \
--to=dinguyen@kernel$(echo .)org \
--cc=dbgh9129@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox