From: Jun Yan <jerrysteve1101@gmail•com>
To: linusw@kernel•org, dmitry.baryshkov@oss•qualcomm.com,
Lee Jones <lee@kernel•org>, Pavel Machek <pavel@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Andrew Lunn <andrew@lunn•ch>,
Gregory Clement <gregory.clement@bootlin•com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>,
Bartosz Golaszewski <brgl@kernel•org>,
Vincent Knecht <vincent.knecht@mailoo•org>,
Grant Feng <von81@163•com>,
Andre Przywara <andre.przywara@arm•com>,
Tony Lindgren <tony@atomide•com>,
Sudeep Holla <sudeep.holla@kernel•org>,
Romain Perier <romain.perier@gmail•com>,
Jesper Nilsson <jesper.nilsson@axis•com>,
Robert Marko <robert.marko@sartura•hr>
Cc: Jun Yan <jerrysteve1101@gmail•com>, Pavel Machek <pavel@ucw•cz>,
Krzysztof Kozlowski <krzk@kernel•org>,
Wei Xu <xuwei5@hisilicon•com>,
Geert Uytterhoeven <geert+renesas@glider•be>,
Peter Rosin <peda@axentia•se>,
linux-leds@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-arm-msm@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-gpio@vger•kernel.org
Subject: [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line
Date: Mon, 25 May 2026 22:46:09 +0800 [thread overview]
Message-ID: <20260525144629.498630-4-jerrysteve1101@gmail.com> (raw)
In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com>
According to the IS31FL319x datasheet[1], the SDB pin is active‑low.
However, existing device tree incorrectly configure it as active‑high.
Add a fixup to force the consumer active low for legacy device trees.
[1] https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf
Signed-off-by: Jun Yan <jerrysteve1101@gmail•com>
---
drivers/gpio/gpiolib-of.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index ef1ac68b94b7..8a79aaadc9ea 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -194,6 +194,16 @@ static void of_gpio_try_fixup_polarity(const struct device_node *np,
{ "himax,hx8357", "gpios-reset", false },
{ "himax,hx8369", "gpios-reset", false },
#endif
+#if IS_ENABLED(CONFIG_LEDS_IS31FL319X)
+ /*
+ * According to the IS31FL319x datasheet, the SDB pin is active‑low.
+ * However, existing device tree incorrectly configure it
+ * as active‑high.
+ */
+ { "issi,is31fl3199", "shutdown-gpios", false },
+ { "si-en,sn3190", "shutdown-gpios", false },
+ { "si-en,sn3193", "shutdown-gpios", false },
+#endif
#if IS_ENABLED(CONFIG_MTD_NAND_JZ4780)
/*
* The rb-gpios semantics was undocumented and qi,lb60 (along with
--
2.54.0
next prev parent reply other threads:[~2026-05-25 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 14:46 [PATCH v2 0/6] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-25 14:46 ` [PATCH v2 1/6] dt-bindings: leds: issi,is31fl319x: Update description for the shutdown-gpios property Jun Yan
2026-05-25 14:46 ` [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-06-01 8:20 ` Krzysztof Kozlowski
2026-05-25 14:46 ` Jun Yan [this message]
2026-05-26 8:40 ` [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line Bartosz Golaszewski
2026-05-29 20:10 ` Linus Walleij
2026-05-25 14:46 ` [PATCH v2 4/6] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Jun Yan
2026-05-25 14:46 ` [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 " Jun Yan
2026-05-25 14:46 ` [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-06-01 6:58 ` Gregory CLEMENT
2026-06-01 8:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525144629.498630-4-jerrysteve1101@gmail.com \
--to=jerrysteve1101@gmail$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andre.przywara@arm$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=brgl@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linusw@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=pavel@kernel$(echo .)org \
--cc=pavel@ucw$(echo .)cz \
--cc=peda@axentia$(echo .)se \
--cc=robert.marko@sartura$(echo .)hr \
--cc=robh@kernel$(echo .)org \
--cc=romain.perier@gmail$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=sudeep.holla@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=vincent.knecht@mailoo$(echo .)org \
--cc=von81@163$(echo .)com \
--cc=xuwei5@hisilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox