From: Krzysztof Kozlowski <krzk@kernel•org>
To: Jun Yan <jerrysteve1101@gmail•com>,
linusw@kernel•org, dmitry.baryshkov@oss•qualcomm.com,
Lee Jones <lee@kernel•org>, Pavel Machek <pavel@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Andrew Lunn <andrew@lunn•ch>,
Gregory Clement <gregory.clement@bootlin•com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>,
Bartosz Golaszewski <brgl@kernel•org>,
Vincent Knecht <vincent.knecht@mailoo•org>,
Grant Feng <von81@163•com>,
Andre Przywara <andre.przywara@arm•com>,
Geert Uytterhoeven <geert+renesas@glider•be>,
Viresh Kumar <viresh.kumar@linaro•org>,
Florian Fainelli <f.fainelli@gmail•com>,
Robert Marko <robert.marko@sartura•hr>
Cc: Pavel Machek <pavel@ucw•cz>, Shawn Guo <shawnguo@kernel•org>,
Michal Simek <michal.simek@amd•com>,
Heiko Stuebner <heiko@sntech•de>,
linux-leds@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-arm-msm@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-gpio@vger•kernel.org
Subject: Re: [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse
Date: Mon, 1 Jun 2026 10:20:13 +0200 [thread overview]
Message-ID: <6aa6061c-1b87-4322-9abe-ad5bd1c74a70@kernel.org> (raw)
In-Reply-To: <20260525144629.498630-3-jerrysteve1101@gmail.com>
On 25/05/2026 16:46, Jun Yan wrote:
> 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is
> active-low.
>
> Fix incorrect initial GPIO level to properly release the chip from shutdown
> state.
>
> 2. According to datasheet [1] definition:
> Shutdown mode can either be used as a means of
> reducing power consumption or generating a flashing
> display (repeatedly entering and leaving shutdown
> mode). During shutdown mode all registers retain their
> data.
> shutdown mode does NOT perform chip reset.A dedicated software reset is
> already implemented in driver by writing 0 to reset chip.
>
> Remove redundant unnecessary toggling of the shutdown GPIO.
>
> [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
>
> Fixes: dddb4e38c6ba ("leds: is31fl319x: Add shutdown pin and generate a 5ms low pulse when startup")
> Signed-off-by: Jun Yan <jerrysteve1101@gmail•com>
> ---
> drivers/leds/leds-is31fl319x.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c
> index e411cee06dab..41087ed262cb 100644
> --- a/drivers/leds/leds-is31fl319x.c
> +++ b/drivers/leds/leds-is31fl319x.c
> @@ -396,7 +396,10 @@ static int is31fl319x_parse_fw(struct device *dev, struct is31fl319x_chip *is31)
> int count;
> int ret;
>
> - is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH);
> + /* Driving this GPIO line low (in fact high) takes the chip out of shutdown,
> + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tree).
> + */
> + is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_LOW);
That's ABI break.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-01 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 14:46 [PATCH v2 0/6] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-25 14:46 ` [PATCH v2 1/6] dt-bindings: leds: issi,is31fl319x: Update description for the shutdown-gpios property Jun Yan
2026-05-25 14:46 ` [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-06-01 8:20 ` Krzysztof Kozlowski [this message]
2026-05-25 14:46 ` [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line Jun Yan
2026-05-26 8:40 ` Bartosz Golaszewski
2026-05-29 20:10 ` Linus Walleij
2026-05-25 14:46 ` [PATCH v2 4/6] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Jun Yan
2026-05-25 14:46 ` [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 " Jun Yan
2026-05-25 14:46 ` [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-06-01 6:58 ` Gregory CLEMENT
2026-06-01 8:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa6061c-1b87-4322-9abe-ad5bd1c74a70@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=andersson@kernel$(echo .)org \
--cc=andre.przywara@arm$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=brgl@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=jerrysteve1101@gmail$(echo .)com \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linusw@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=michal.simek@amd$(echo .)com \
--cc=pavel@kernel$(echo .)org \
--cc=pavel@ucw$(echo .)cz \
--cc=robert.marko@sartura$(echo .)hr \
--cc=robh@kernel$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=vincent.knecht@mailoo$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=von81@163$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox