* [PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc
@ 2026-05-28 20:24 Rosen Penev
2026-06-03 10:15 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-28 20:24 UTC (permalink / raw)
To: linux-pm
Cc: Ulf Hansson, Matthias Brugger, AngeloGioacchino Del Regno,
open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
The kernel-doc parser cannot parse 'struct __packed mtk_mfg_opp_entry {'.
Move __packed to the closing brace, which is the more common kernel style.
Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail•com>
---
drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
index 3ce6fb74dd53..53bdab66cf15 100644
--- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
+++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
@@ -236,14 +236,14 @@ struct __packed mtk_mfg_ipi_sleep_msg {
*
* This struct is part of the ABI with the EB firmware. Do not change it.
*/
-struct __packed mtk_mfg_opp_entry {
+struct mtk_mfg_opp_entry {
__le32 freq_khz;
__le32 voltage_core;
__le32 voltage_sram;
__le32 posdiv;
__le32 voltage_margin;
__le32 power_mw;
-};
+} __packed;
struct mtk_mfg_mbox {
struct mbox_client cl;
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc
2026-05-28 20:24 [PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc Rosen Penev
@ 2026-06-03 10:15 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2026-06-03 10:15 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-pm, Ulf Hansson, Matthias Brugger,
AngeloGioacchino Del Regno, open list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Thu, May 28, 2026 at 10:25 PM Rosen Penev <rosenp@gmail•com> wrote:
>
> The kernel-doc parser cannot parse 'struct __packed mtk_mfg_opp_entry {'.
> Move __packed to the closing brace, which is the more common kernel style.
>
> Assisted-by: Opencode:Big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail•com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> index 3ce6fb74dd53..53bdab66cf15 100644
> --- a/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> +++ b/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c
> @@ -236,14 +236,14 @@ struct __packed mtk_mfg_ipi_sleep_msg {
> *
> * This struct is part of the ABI with the EB firmware. Do not change it.
> */
> -struct __packed mtk_mfg_opp_entry {
> +struct mtk_mfg_opp_entry {
> __le32 freq_khz;
> __le32 voltage_core;
> __le32 voltage_sram;
> __le32 posdiv;
> __le32 voltage_margin;
> __le32 power_mw;
> -};
> +} __packed;
>
> struct mtk_mfg_mbox {
> struct mbox_client cl;
> --
> 2.54.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-03 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 20:24 [PATCH] pmdomain: mediatek: mfg: move __packed after struct name to fix kernel-doc Rosen Penev
2026-06-03 10:15 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox