* [PATCH 0/2] pinctrl: mediatek: Enable MT8189 as loadable module
@ 2026-05-29 10:02 Justin Yeh
2026-05-29 10:02 ` [PATCH 1/2] pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate Justin Yeh
2026-05-29 10:02 ` [PATCH 2/2] pinctrl: mediatek: mt8189: Add MODULE_LICENSE declaration Justin Yeh
0 siblings, 2 replies; 3+ messages in thread
From: Justin Yeh @ 2026-05-29 10:02 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Project_Global_Chrome_Upstream_Group, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, Justin Yeh
This series enables PINCTRL_MT8189 to be built as a loadable kernel
module, which is required for GKI (Generic Kernel Image) + vendor_dlkm
deployments where vendor-specific drivers must be kept separate from
the GKI vmlinux.
Patch 1 restores the tristate option that was recently changed to bool,
preventing module builds. Patch 2 adds the missing MODULE_LICENSE macro
that's required when building as a module.
Together these changes allow MT8189 pinctrl to be properly packaged as
a vendor kernel module while maintaining the existing built-in option.
Justin Yeh (2):
pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate
pinctrl: mediatek: mt8189: Add MODULE_LICENSE declaration
drivers/pinctrl/mediatek/Kconfig | 2 +-
drivers/pinctrl/mediatek/pinctrl-mt8189.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate
2026-05-29 10:02 [PATCH 0/2] pinctrl: mediatek: Enable MT8189 as loadable module Justin Yeh
@ 2026-05-29 10:02 ` Justin Yeh
2026-05-29 10:02 ` [PATCH 2/2] pinctrl: mediatek: mt8189: Add MODULE_LICENSE declaration Justin Yeh
1 sibling, 0 replies; 3+ messages in thread
From: Justin Yeh @ 2026-05-29 10:02 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Project_Global_Chrome_Upstream_Group, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, Justin Yeh
Under the GKI + vendor_dlkm model, vendor-specific pinctrl cannot be
built into the GKI vmlinux. Upstream's recent switch of PINCTRL_MT8189
to bool prevents building as a loadable module, which breaks DDK module
usage. Restore tristate so MT8189 pinctrl can be packaged as a kernel
module in vendor_dlkm.
Signed-off-by: Justin Yeh <justin.yeh@mediatek•com>
---
drivers/pinctrl/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index 4819617d9368..a75434e7e989 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -270,7 +270,7 @@ config PINCTRL_MT8188
map specific eint which doesn't have real gpio pin.
config PINCTRL_MT8189
- bool "MediaTek MT8189 pin control"
+ tristate "MediaTek MT8189 pin control"
depends on OF
depends on ARM64 || COMPILE_TEST
default ARM64 && ARCH_MEDIATEK
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] pinctrl: mediatek: mt8189: Add MODULE_LICENSE declaration
2026-05-29 10:02 [PATCH 0/2] pinctrl: mediatek: Enable MT8189 as loadable module Justin Yeh
2026-05-29 10:02 ` [PATCH 1/2] pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate Justin Yeh
@ 2026-05-29 10:02 ` Justin Yeh
1 sibling, 0 replies; 3+ messages in thread
From: Justin Yeh @ 2026-05-29 10:02 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Project_Global_Chrome_Upstream_Group, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, Justin Yeh
Add missing MODULE_LICENSE("GPL v2") macro to fix modpost error during
kernel module build. The license identifier matches the SPDX header
(GPL-2.0) at the top of the file.
This fixes the following build error:
ERROR: modpost: missing MODULE_LICENSE() in pinctrl-mt8189.o
Signed-off-by: Justin Yeh <justin.yeh@mediatek•com>
---
drivers/pinctrl/mediatek/pinctrl-mt8189.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8189.c b/drivers/pinctrl/mediatek/pinctrl-mt8189.c
index cd4cdff309a1..a9c128c514a4 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8189.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8189.c
@@ -1696,3 +1696,4 @@ static int __init mt8189_pinctrl_init(void)
arch_initcall(mt8189_pinctrl_init);
MODULE_DESCRIPTION("MediaTek MT8189 Pinctrl Driver");
+MODULE_LICENSE("GPL v2");
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-29 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 10:02 [PATCH 0/2] pinctrl: mediatek: Enable MT8189 as loadable module Justin Yeh
2026-05-29 10:02 ` [PATCH 1/2] pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate Justin Yeh
2026-05-29 10:02 ` [PATCH 2/2] pinctrl: mediatek: mt8189: Add MODULE_LICENSE declaration Justin Yeh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox