* [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
@ 2026-05-29 13:48 Stefano Radaelli
2026-06-01 20:42 ` Frank Li
2026-06-03 18:03 ` Frank.Li
0 siblings, 2 replies; 4+ messages in thread
From: Stefano Radaelli @ 2026-05-29 13:48 UTC (permalink / raw)
To: Frank Li, linux-kernel, devicetree, imx
Cc: pierluigi.p, Stefano Radaelli, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
From: Stefano Radaelli <stefano.r@variscite•com>
RGB_SEL is a board-level signal driven by the PCAL6408 GPIO expander on
the Symphony carrier board.
The signal needs to be driven high on the i.MX91 variant to keep the
board in the expected display configuration. Move the handling of this
line from a fixed regulator tied to the PCAL6408 supply to a GPIO hog on
the correct GPIO expander.
Fixes: b3292129dcef ("arm64: dts: imx91-var-som: Add support for Variscite Symphony board")
Signed-off-by: Stefano Radaelli <stefano.r@variscite•com>
---
.../dts/freescale/imx91-var-som-symphony.dts | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
index ac9fed58357e..c1e6c9978275 100644
--- a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
@@ -97,13 +97,6 @@ reg_fec_phy: regulator-fec-phy {
regulator-always-on;
};
- reg_rgb_sel: regulator-rgb-enable {
- compatible = "regulator-fixed";
- regulator-name = "RGBSEL";
- gpio = <&pca9534 7 GPIO_ACTIVE_HIGH>;
- enable-active-high;
- };
-
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
regulator-name = "VSD_3V3";
@@ -258,7 +251,6 @@ pca6408: gpio@21 {
#interrupt-cells = <2>;
interrupt-parent = <&gpio2>;
interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
- vcc-supply = <®_rgb_sel>;
wakeup-source;
tpm-enable-hog {
@@ -267,6 +259,14 @@ tpm-enable-hog {
output-high;
line-name = "tpm_en";
};
+
+ /* RGB_SEL */
+ lvds-brg-enable-hog {
+ gpio-hog;
+ gpios = <7 GPIO_ACTIVE_HIGH>;
+ output-high;
+ line-name = "lvds_brg_en";
+ };
};
/* USB Type-C Controller */
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
2026-05-29 13:48 [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling Stefano Radaelli
@ 2026-06-01 20:42 ` Frank Li
2026-06-03 9:12 ` Stefano Radaelli
2026-06-03 18:03 ` Frank.Li
1 sibling, 1 reply; 4+ messages in thread
From: Frank Li @ 2026-06-01 20:42 UTC (permalink / raw)
To: Stefano Radaelli
Cc: linux-kernel, devicetree, imx, pierluigi.p, Stefano Radaelli,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
On Fri, May 29, 2026 at 03:48:50PM +0200, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite•com>
>
> RGB_SEL is a board-level signal driven by the PCAL6408 GPIO expander on
> the Symphony carrier board.
>
> The signal needs to be driven high on the i.MX91 variant to keep the
> board in the expected display configuration. Move the handling of this
> line from a fixed regulator tied to the PCAL6408 supply to a GPIO hog on
> the correct GPIO expander.
Look like this can't resolve your problem. gpio driver may probe later
than display, so gpio-hog may not set correct when display setup.
Frank
>
> Fixes: b3292129dcef ("arm64: dts: imx91-var-som: Add support for Variscite Symphony board")
> Signed-off-by: Stefano Radaelli <stefano.r@variscite•com>
> ---
> .../dts/freescale/imx91-var-som-symphony.dts | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> index ac9fed58357e..c1e6c9978275 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> @@ -97,13 +97,6 @@ reg_fec_phy: regulator-fec-phy {
> regulator-always-on;
> };
>
> - reg_rgb_sel: regulator-rgb-enable {
> - compatible = "regulator-fixed";
> - regulator-name = "RGBSEL";
> - gpio = <&pca9534 7 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - };
> -
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> regulator-name = "VSD_3V3";
> @@ -258,7 +251,6 @@ pca6408: gpio@21 {
> #interrupt-cells = <2>;
> interrupt-parent = <&gpio2>;
> interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> - vcc-supply = <®_rgb_sel>;
> wakeup-source;
>
> tpm-enable-hog {
> @@ -267,6 +259,14 @@ tpm-enable-hog {
> output-high;
> line-name = "tpm_en";
> };
> +
> + /* RGB_SEL */
> + lvds-brg-enable-hog {
> + gpio-hog;
> + gpios = <7 GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "lvds_brg_en";
> + };
> };
>
> /* USB Type-C Controller */
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
2026-06-01 20:42 ` Frank Li
@ 2026-06-03 9:12 ` Stefano Radaelli
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Radaelli @ 2026-06-03 9:12 UTC (permalink / raw)
To: Frank Li
Cc: linux-kernel, devicetree, imx, pierluigi.p, Stefano Radaelli,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
Hi Frank,
On Mon, Jun 01, 2026 at 04:42:32PM -0400, Frank Li wrote:
> On Fri, May 29, 2026 at 03:48:50PM +0200, Stefano Radaelli wrote:
> > From: Stefano Radaelli <stefano.r@variscite•com>
> >
> > RGB_SEL is a board-level signal driven by the PCAL6408 GPIO expander on
> > the Symphony carrier board.
> >
> > The signal needs to be driven high on the i.MX91 variant to keep the
> > board in the expected display configuration. Move the handling of this
> > line from a fixed regulator tied to the PCAL6408 supply to a GPIO hog on
> > the correct GPIO expander.
>
> Look like this can't resolve your problem. gpio driver may probe later
> than display, so gpio-hog may not set correct when display setup.
>
> Frank
> >
thanks for looking at this.
The main issue I am trying to fix here is that the current upstream DT
describes RGB_SEL on the wrong GPIO expander.
The existing DT drives RGB_SEL from pca9534 GPIO 7 and also uses it as a
fake supply for the pca6408. That is not correct for this board. RGB_SEL
is actually connected to pca6408 GPIO 7, so the current description does
not drive the intended line at all.
With this change, RGB_SEL is driven by the correct GPIO controller and
this fixes the hardware configuration issue I am seeing on the i.MX91
Symphpony board, making it working now as expected.
Best Regards,
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
2026-05-29 13:48 [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling Stefano Radaelli
2026-06-01 20:42 ` Frank Li
@ 2026-06-03 18:03 ` Frank.Li
1 sibling, 0 replies; 4+ messages in thread
From: Frank.Li @ 2026-06-03 18:03 UTC (permalink / raw)
To: linux-kernel, devicetree, imx, Stefano Radaelli
Cc: Frank Li, pierluigi.p, Stefano Radaelli, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
From: Frank Li <Frank.Li@nxp•com>
On Fri, 29 May 2026 15:48:50 +0200, Stefano Radaelli wrote:
> RGB_SEL is a board-level signal driven by the PCAL6408 GPIO expander on
> the Symphony carrier board.
>
> The signal needs to be driven high on the i.MX91 variant to keep the
> board in the expected display configuration. Move the handling of this
> line from a fixed regulator tied to the PCAL6408 supply to a GPIO hog on
> the correct GPIO expander.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
commit: b3801c6dd15f9dfebeba25b2308dd5143016d52d
Best regards,
--
Frank Li <Frank.Li@nxp•com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-03 18:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 13:48 [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling Stefano Radaelli
2026-06-01 20:42 ` Frank Li
2026-06-03 9:12 ` Stefano Radaelli
2026-06-03 18:03 ` Frank.Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox