* [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions
@ 2026-05-30 19:59 Rosen Penev
2026-06-02 7:18 ` Laurentiu Palcu
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-30 19:59 UTC (permalink / raw)
To: dri-devel
Cc: Laurentiu Palcu, Lucas Stach, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
dcss_scaler_gaussian_filter() was missing @phase0_identity and
dcss_scaler_filter_design() was missing @phase0_identity and
@nn_interpolation in their kernel-doc comments.
Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail•com>
---
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 32c3f46b21da..e48b3117efb9 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
* dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
* @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
* @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: use identity filter for phase 0
* @coef: output filter coefficients
*/
static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
* @src_length: length of input
* @dst_length: length of output
* @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: use identity filter for phase 0
* @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
*/
static void dcss_scaler_filter_design(int src_length, int dst_length,
bool use_5_taps, bool phase0_identity,
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions
2026-05-30 19:59 [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions Rosen Penev
@ 2026-06-02 7:18 ` Laurentiu Palcu
0 siblings, 0 replies; 2+ messages in thread
From: Laurentiu Palcu @ 2026-06-02 7:18 UTC (permalink / raw)
To: Rosen Penev
Cc: dri-devel, Lucas Stach, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Hi,
There was already a fix sent for this:
https://lore.kernel.org/all/20260406180013.2442096-1-yiconghui@gmail.com/
On Sat, May 30, 2026 at 12:59:25PM -0700, Rosen Penev wrote:
> dcss_scaler_gaussian_filter() was missing @phase0_identity and
> dcss_scaler_filter_design() was missing @phase0_identity and
> @nn_interpolation in their kernel-doc comments.
>
> Assisted-by: Opencode:Big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail•com>
> ---
> drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index 32c3f46b21da..e48b3117efb9 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -166,6 +166,7 @@ static int exp_approx_q(int x)
> * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
> * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
> * @use_5_taps: indicates whether to use 5 taps or 7 taps
> + * @phase0_identity: use identity filter for phase 0
> * @coef: output filter coefficients
> */
> static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> @@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
> * @src_length: length of input
> * @dst_length: length of output
> * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
> + * @phase0_identity: use identity filter for phase 0
> * @coef: output coefficients
> + * @nn_interpolation: use nearest neighbor interpolation
> */
> static void dcss_scaler_filter_design(int src_length, int dst_length,
> bool use_5_taps, bool phase0_identity,
> --
> 2.54.0
>
--
Thanks,
Laurentiu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-02 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 19:59 [PATCH] drm/imx/dcss: add missing kernel-doc parameters for scaler functions Rosen Penev
2026-06-02 7:18 ` Laurentiu Palcu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox