* [PATCH] soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
@ 2019-10-17 12:30 Ben Dooks (Codethink)
2019-10-17 14:43 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 12:30 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks (Codethink), Andreas Färber, linux-arm-kernel,
Manivannan Sadhasivam
Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
declaration to fix the following sparse warning:
drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol 'owl_sps_set_pg' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
---
Cc: "Andreas Färber" <afaerber@suse•de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
Cc: linux-arm-kernel@lists•infradead.org
---
drivers/soc/actions/owl-sps-helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/actions/owl-sps-helper.c b/drivers/soc/actions/owl-sps-helper.c
index 291a206d6f04..f35cf3c6d23c 100644
--- a/drivers/soc/actions/owl-sps-helper.c
+++ b/drivers/soc/actions/owl-sps-helper.c
@@ -11,6 +11,8 @@
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/soc/actions/owl-sps.h>
+
#define OWL_SPS_PG_CTL 0x0
int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask, bool enable)
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
2019-10-17 12:30 [PATCH] soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg Ben Dooks (Codethink)
@ 2019-10-17 14:43 ` Andreas Färber
2019-10-17 15:53 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2019-10-17 14:43 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: linux-kernel, linux-arm-kernel, Manivannan Sadhasivam
Hello Ben,
Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks
(Codethink):
> Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
> declaration to fix the following sparse warning:
>
> drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol
> 'owl_sps_set_pg' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
> ---
> Cc: "Andreas Färber" <afaerber@suse•de>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
> Cc: linux-arm-kernel@lists•infradead.org
> ---
> drivers/soc/actions/owl-sps-helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/actions/owl-sps-helper.c
> b/drivers/soc/actions/owl-sps-helper.c
> index 291a206d6f04..f35cf3c6d23c 100644
> --- a/drivers/soc/actions/owl-sps-helper.c
> +++ b/drivers/soc/actions/owl-sps-helper.c
> @@ -11,6 +11,8 @@
> #include <linux/delay.h>
> #include <linux/io.h>
>
> +#include <linux/soc/actions/owl-sps.h>
Any reason for the white line before?
Also, could you explain why we did not get that warning during earlier
builds? Should there be a Fixes?
Thanks,
Andreas
> +
> #define OWL_SPS_PG_CTL 0x0
>
> int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask,
> bool enable)
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
2019-10-17 14:43 ` Andreas Färber
@ 2019-10-17 15:53 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-17 15:53 UTC (permalink / raw)
To: Andreas Färber; +Cc: linux-kernel, linux-arm-kernel, Manivannan Sadhasivam
On 17/10/2019 15:43, Andreas Färber wrote:
> Hello Ben,
>
> Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks
> (Codethink):
>> Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg
>> declaration to fix the following sparse warning:
>>
>> drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol
>> 'owl_sps_set_pg' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
>> ---
>> Cc: "Andreas Färber" <afaerber@suse•de>
>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>
>> Cc: linux-arm-kernel@lists•infradead.org
>> ---
>> drivers/soc/actions/owl-sps-helper.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/soc/actions/owl-sps-helper.c
>> b/drivers/soc/actions/owl-sps-helper.c
>> index 291a206d6f04..f35cf3c6d23c 100644
>> --- a/drivers/soc/actions/owl-sps-helper.c
>> +++ b/drivers/soc/actions/owl-sps-helper.c
>> @@ -11,6 +11,8 @@
>> #include <linux/delay.h>
>> #include <linux/io.h>
>>
>> +#include <linux/soc/actions/owl-sps.h>
>
> Any reason for the white line before?
I added it as some people tend to when moving onto
a new group of includes in a different directory.
> Also, could you explain why we did not get that warning during earlier
> builds? Should there be a Fixes?
It is a warning from sparse, so not run as standard when building.
I've not been putting fixes on as it isn't really a bug.
> Thanks,
> Andreas
>
>> +
>> #define OWL_SPS_PG_CTL 0x0
>>
>> int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask,
>> bool enable)
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 12:30 [PATCH] soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg Ben Dooks (Codethink)
2019-10-17 14:43 ` Andreas Färber
2019-10-17 15:53 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox