* [PATCH -next] media: sun6i: Make sun4i_csi_formats static
@ 2019-08-27 7:06 YueHaibing
2019-08-27 7:20 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-08-27 7:06 UTC (permalink / raw)
To: mripard, mchehab, wens, maxime.ripard, sakari.ailus
Cc: YueHaibing, linux-kernel, linux-arm-kernel, linux-media
Fix sparse warning:
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31:
warning: symbol 'sun4i_csi_formats' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei•com>
Signed-off-by: YueHaibing <yuehaibing@huawei•com>
---
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
index 772b0fc..83a3a02 100644
--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
+++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
@@ -18,7 +18,7 @@
#define CSI_DEFAULT_WIDTH 640
#define CSI_DEFAULT_HEIGHT 480
-const struct sun4i_csi_format sun4i_csi_formats[] = {
+static const struct sun4i_csi_format sun4i_csi_formats[] = {
/* YUV422 inputs */
{
.mbus = MEDIA_BUS_FMT_YUYV8_2X8,
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: sun6i: Make sun4i_csi_formats static
2019-08-27 7:06 [PATCH -next] media: sun6i: Make sun4i_csi_formats static YueHaibing
@ 2019-08-27 7:20 ` Sakari Ailus
2019-08-27 7:23 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2019-08-27 7:20 UTC (permalink / raw)
To: YueHaibing
Cc: maxime.ripard, linux-kernel, mripard, wens, mchehab,
linux-arm-kernel, linux-media
Hi Yue,
On Tue, Aug 27, 2019 at 03:06:23PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31:
> warning: symbol 'sun4i_csi_formats' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei•com>
> Signed-off-by: YueHaibing <yuehaibing@huawei•com>
Thanks for the patch.
This has been already addressed by another patch:
<URL:https://patchwork.linuxtv.org/patch/58395/>
--
Sakari Ailus
sakari.ailus@linux•intel.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: sun6i: Make sun4i_csi_formats static
2019-08-27 7:20 ` Sakari Ailus
@ 2019-08-27 7:23 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-08-27 7:23 UTC (permalink / raw)
To: Sakari Ailus
Cc: maxime.ripard, linux-kernel, mripard, wens, mchehab,
linux-arm-kernel, linux-media
On 2019/8/27 15:20, Sakari Ailus wrote:
> Hi Yue,
>
> On Tue, Aug 27, 2019 at 03:06:23PM +0800, YueHaibing wrote:
>> Fix sparse warning:
>>
>> drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:21:31:
>> warning: symbol 'sun4i_csi_formats' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei•com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei•com>
>
> Thanks for the patch.
>
> This has been already addressed by another patch:
>
> <URL:https://patchwork.linuxtv.org/patch/58395/>
OK, thank you!
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 7:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-27 7:06 [PATCH -next] media: sun6i: Make sun4i_csi_formats static YueHaibing
2019-08-27 7:20 ` Sakari Ailus
2019-08-27 7:23 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox