From: jy0922.shim@samsung•com (Joonyoung Shim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Date: Wed, 21 Jul 2010 14:42:22 +0900 [thread overview]
Message-ID: <4C4688BE.1080409@samsung.com> (raw)
In-Reply-To: <4C36D235.3040702@samsung.com>
Hi, Dmitry.
On 7/9/2010 4:39 PM, Joonyoung Shim wrote:
> On 7/9/2010 4:07 PM, Kukjin Kim wrote:
>> Joonyoung Shim wrote:
>>> On 7/7/2010 8:52 AM, Kukjin Kim wrote:
>>>> Joonyoung Shim wrote:
>>>>> Hi, Naveen.
>>>>>
>>>>> On 6/28/2010 8:33 PM, Joonyoung Shim wrote:
>>>>>> This patch adds support for keypad driver running on Samsung cpus. This
>>>>>> driver is tested on GONI and Aquila board using S5PC110 cpu.
>>>>>>
>>>>>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung•com>
>>>>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung•com>
>>>>>> ---
>>>>>> drivers/input/keyboard/Kconfig | 9 +
>>>>>> drivers/input/keyboard/Makefile | 1 +
>>>>>> drivers/input/keyboard/samsung-keypad.c | 491
>>>>> +++++++++++++++++++++++++++++++
>>>>>> 3 files changed, 501 insertions(+), 0 deletions(-)
>>>>>> create mode 100644 drivers/input/keyboard/samsung-keypad.c
>>>>>>
>>>>> Could you please test this v6 keypad driver on your various targets?
>>>> Hi,
>>>>
>>>> I received the test result from Naveen.
>>>> And now he is debugging about that.
>>>>
>>>> ..his e-mail client has some problem..so I replied...
>>>>
>>>> ---
>>>> From: Naveen Ch
>>>>
>>>> I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100
>>> and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-
>>> keypad.c.
>>>> The build breaking error is like following:
>>>> (make s5pc100_defconfig and select input->keypad->samsung keypad)
>>>>
>>>> drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
>>>> drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE'
>>> undeclared (first use in this function)
>>>> drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier
>>> is reported only once
>>>> drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears
>>> in.)
>>>> drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of
>>> function 'schedule_timeout'
>>>> drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
>>>> drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'
>>> undeclared (first use in this function)
>>>> make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
>>>>
>>> This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT
>>> option. I think sched.h should be included to remove like this
>>> dependency in driver, are there other ways?
>> I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem.
>> Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions...
>
> The sched.h is included by below path.
>
> interrupt.h -> hardirq.h -> smp_lock.h -> sched.h
>
> The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined.
> The samsung keypad driver haven't needed including sched.h before
> Dmitry's patch is applied..
>
>> Anyway, if no any issues, could you please re-submit updated it soon?
>
> I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.
>
Ping.
Do you have any feedback? If ok, i want to go to input tree or samsung
tree these added sched.h including.
next prev parent reply other threads:[~2010-07-21 5:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 11:33 [PATCH v6 1/3] ARM: SAMSUNG: Add keypad device support Joonyoung Shim
2010-06-28 11:33 ` [PATCH v6 2/3] ARM: S5PV210: Add keypad device helpers Joonyoung Shim
2010-06-28 11:33 ` [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver Joonyoung Shim
2010-07-06 7:58 ` Joonyoung Shim
2010-07-06 23:52 ` Kukjin Kim
2010-07-07 1:28 ` Joonyoung Shim
2010-07-09 7:07 ` Kukjin Kim
2010-07-09 7:39 ` Joonyoung Shim
2010-07-21 5:42 ` Joonyoung Shim [this message]
2010-07-21 6:21 ` Kukjin Kim
2010-07-21 8:07 ` Dmitry Torokhov
2010-07-21 9:01 ` Joonyoung Shim
2010-07-21 12:39 ` Kukjin Kim
2010-08-02 3:09 ` Joonyoung Shim
2010-08-02 3:38 ` Kukjin Kim
2010-08-02 4:41 ` Joonyoung Shim
2010-08-02 5:12 ` Kukjin Kim
2010-08-02 5:52 ` Joonyoung Shim
2010-08-02 6:30 ` Kukjin Kim
2010-08-02 7:58 ` Dmitry Torokhov
2010-08-03 2:10 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4688BE.1080409@samsung.com \
--to=jy0922.shim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox