From: jy0922.shim@samsung•com (Joonyoung Shim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Date: Mon, 02 Aug 2010 13:41:14 +0900 [thread overview]
Message-ID: <4C564C6A.9040204@samsung.com> (raw)
In-Reply-To: <019a01cb31f4$226a8aa0$673f9fe0$%kim@samsung.com>
On 8/2/2010 12:38 PM, Kukjin Kim wrote:
> Joonyoung Shim wrote:
>> Hi, I came back from vacation.
>>
>>>>>> Do you have any feedback? If ok, i want to go to input tree or samsung
>>>>>> tree these added sched.h including.
>>>>> I applied the patch adding samsung-keypad.c and the platform data
>>>>> arch/arm/plat-samsung/include/plat/keypad.h and I expect that
>>>>> patches to actually enable keypad will go through appropriate
>>>>> platform tree(s).
>>>>>
>>>> OK, the rest will go through samsung platform tree
>>>>
>>> Ok..will apply.
>>>
>> Kukjin, could you remove keypad.h on the commit "ARM: SAMSUNG: Add
>> keypad device support" of the samsung platform tree. The keypad.h file
>> was included on input tree.
>> (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7
>> a34de9fe017b7082b5958bb93)
>
> You mean in plat-samsung/dev-keypad.c?
> If remove inclusion plat/keypad.h in there, following build error happens.
>
No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on
samsung platform tree, it was applied on input tree already. If needs, i
can repost.
> arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list
> arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata':
> arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata'
> arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type
> arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type
> arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function)
> arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once
> arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.)
> make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1
>
> As you know, released 35 today. So we have no much time for this merge window.
>
I'm not sure about merge rule, but I think the compile problem can be
solved by merge to 36 of input tree and samsung platform tree.
next prev parent reply other threads:[~2010-08-02 4:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 11:33 [PATCH v6 1/3] ARM: SAMSUNG: Add keypad device support Joonyoung Shim
2010-06-28 11:33 ` [PATCH v6 2/3] ARM: S5PV210: Add keypad device helpers Joonyoung Shim
2010-06-28 11:33 ` [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver Joonyoung Shim
2010-07-06 7:58 ` Joonyoung Shim
2010-07-06 23:52 ` Kukjin Kim
2010-07-07 1:28 ` Joonyoung Shim
2010-07-09 7:07 ` Kukjin Kim
2010-07-09 7:39 ` Joonyoung Shim
2010-07-21 5:42 ` Joonyoung Shim
2010-07-21 6:21 ` Kukjin Kim
2010-07-21 8:07 ` Dmitry Torokhov
2010-07-21 9:01 ` Joonyoung Shim
2010-07-21 12:39 ` Kukjin Kim
2010-08-02 3:09 ` Joonyoung Shim
2010-08-02 3:38 ` Kukjin Kim
2010-08-02 4:41 ` Joonyoung Shim [this message]
2010-08-02 5:12 ` Kukjin Kim
2010-08-02 5:52 ` Joonyoung Shim
2010-08-02 6:30 ` Kukjin Kim
2010-08-02 7:58 ` Dmitry Torokhov
2010-08-03 2:10 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C564C6A.9040204@samsung.com \
--to=jy0922.shim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox