From: jason77.wang@gmail•com (Jason Wang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] MX3x: clean kpp resource structure definitions
Date: Tue, 24 Aug 2010 16:56:19 +0800 [thread overview]
Message-ID: <4C738933.6000100@gmail.com> (raw)
In-Reply-To: <20100824083944.GD1536@pengutronix.de>
Uwe Kleine-K?nig wrote:
> Hallo Michael,
>
> On Tue, Aug 24, 2010 at 09:57:39AM +0200, Michael Grzeschik wrote:
>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix•de>
>> ---
>> arch/arm/mach-mx3/devices.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx3/devices.c b/arch/arm/mach-mx3/devices.c
>> index a4fd1a2..a3e0fe2 100644
>> --- a/arch/arm/mach-mx3/devices.c
>> +++ b/arch/arm/mach-mx3/devices.c
>> @@ -374,12 +374,12 @@ struct platform_device imx_rtc_device0 = {
>>
>> static struct resource imx_kpp_resources[] = {
>> {
>> - .start = MX3x_KPP_BASE_ADDR,
>> - .end = MX3x_KPP_BASE_ADDR + 0xf,
>> - .flags = IORESOURCE_MEM
>> + .start = KPP_BASE_ADDR,
>> + .end = KPP_BASE_ADDR + SZ_4K - 1,
>> + .flags = IORESOURCE_MEM,
>> }, {
>> - .start = MX3x_INT_KPP,
>> - .end = MX3x_INT_KPP,
>> + .start = MXC_INT_KPP,
>> + .end = MXC_INT_KPP,
>> .flags = IORESOURCE_IRQ,
>> },
>> };
>>
:) The final goal is to build all i.MX platforms into a single kernel,
your change will add troubles for that.
Regards,
Jason.
> what ist the exact problem you want to fix? I'm OK with adding that
> comma and using SZ_4K (assuming you checked it in the reference
> manuals). But why s/MX3x_KPP_BASE_ADDR/KPP_BASE_ADDR/ ?
>
> Best regards
> Uwe
>
>
prev parent reply other threads:[~2010-08-24 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 7:57 [PATCH] MX3x: clean kpp resource structure definitions Michael Grzeschik
2010-08-24 8:39 ` Uwe Kleine-König
2010-08-24 8:54 ` Michael Grzeschik
2010-08-24 8:56 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C738933.6000100@gmail.com \
--to=jason77.wang@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox