* [PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support @ 2010-10-05 23:09 Maurus Cuelenaere 2010-10-05 23:09 ` [PATCH 1/2] ARM: S3C64XX: Add " Maurus Cuelenaere 2010-10-05 23:10 ` [PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards Maurus Cuelenaere 0 siblings, 2 replies; 8+ messages in thread From: Maurus Cuelenaere @ 2010-10-05 23:09 UTC (permalink / raw) To: linux-arm-kernel These patches add suspend support to the SmartQ (and other S3C64XX) boards. Currently the LCD needs re-initializing when waking up, otherwise it'll just display a WSOD. This was tested on a SmartQ 7. Maurus Cuelenaere (2): ARM: S3C64XX: Add suspend support ARM: S3C64XX: Add wakeup sources to SmartQ boards arch/arm/mach-s3c64xx/mach-smartq5.c | 1 + arch/arm/mach-s3c64xx/mach-smartq7.c | 1 + arch/arm/mach-s3c64xx/pm.c | 3 +++ 3 files changed, 5 insertions(+), 0 deletions(-) -- 1.7.2.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-05 23:09 [PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support Maurus Cuelenaere @ 2010-10-05 23:09 ` Maurus Cuelenaere 2010-10-05 23:23 ` Kyungmin Park 2010-10-05 23:10 ` [PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards Maurus Cuelenaere 1 sibling, 1 reply; 8+ messages in thread From: Maurus Cuelenaere @ 2010-10-05 23:09 UTC (permalink / raw) To: linux-arm-kernel The only missing thing for SoC-wide suspend support, is a call to s3c_pm_init, so add that. This was tested on a S3C6410 SmartQ 7. Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail•com> --- arch/arm/mach-s3c64xx/pm.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c index 79412f7..db292c9 100644 --- a/arch/arm/mach-s3c64xx/pm.c +++ b/arch/arm/mach-s3c64xx/pm.c @@ -187,6 +187,9 @@ static int s3c64xx_pm_init(void) pm_cpu_prep = s3c64xx_pm_prepare; pm_cpu_sleep = s3c64xx_cpu_suspend; pm_uart_udivslot = 1; + + s3c_pm_init(); + return 0; } -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-05 23:09 ` [PATCH 1/2] ARM: S3C64XX: Add " Maurus Cuelenaere @ 2010-10-05 23:23 ` Kyungmin Park 2010-10-05 23:27 ` Maurus Cuelenaere 2010-10-06 22:22 ` Ben Dooks 0 siblings, 2 replies; 8+ messages in thread From: Kyungmin Park @ 2010-10-05 23:23 UTC (permalink / raw) To: linux-arm-kernel Hi, I agree your approach, put the common features in common place. but Samsung maintainers insist put these at each machine file at current time. So move this to the each machines for their tastes. Thank you, Kyungmin Park On Wed, Oct 6, 2010 at 8:09 AM, Maurus Cuelenaere <mcuelenaere@gmail•com> wrote: > The only missing thing for SoC-wide suspend support, is a call to s3c_pm_init, > so add that. This was tested on a S3C6410 SmartQ 7. > > Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail•com> > --- > ?arch/arm/mach-s3c64xx/pm.c | ? ?3 +++ > ?1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c > index 79412f7..db292c9 100644 > --- a/arch/arm/mach-s3c64xx/pm.c > +++ b/arch/arm/mach-s3c64xx/pm.c > @@ -187,6 +187,9 @@ static int s3c64xx_pm_init(void) > ? ? ? ?pm_cpu_prep = s3c64xx_pm_prepare; > ? ? ? ?pm_cpu_sleep = s3c64xx_cpu_suspend; > ? ? ? ?pm_uart_udivslot = 1; > + > + ? ? ? s3c_pm_init(); > + > ? ? ? ?return 0; > ?} > > -- > 1.7.2.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-05 23:23 ` Kyungmin Park @ 2010-10-05 23:27 ` Maurus Cuelenaere 2010-10-05 23:39 ` Kyungmin Park 2010-10-06 22:22 ` Ben Dooks 1 sibling, 1 reply; 8+ messages in thread From: Maurus Cuelenaere @ 2010-10-05 23:27 UTC (permalink / raw) To: linux-arm-kernel Op 06-10-10 01:23, Kyungmin Park schreef: > Hi, > > I agree your approach, put the common features in common place. > but Samsung maintainers insist put these at each machine file at current time. > > So move this to the each machines for their tastes. I did it that way first, but then wondered why this wasn't done for all boards. When looking at some S3C24XX boards, you'll see that these need changes to the bootloader to support suspend; but IIRC this isn't needed for S3C64XX so I think this can be safely enabled for all S3C64XX boards? -- Maurus Cuelenaere ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-05 23:27 ` Maurus Cuelenaere @ 2010-10-05 23:39 ` Kyungmin Park 0 siblings, 0 replies; 8+ messages in thread From: Kyungmin Park @ 2010-10-05 23:39 UTC (permalink / raw) To: linux-arm-kernel On Wed, Oct 6, 2010 at 8:27 AM, Maurus Cuelenaere <mcuelenaere@gmail•com> wrote: > ?Op 06-10-10 01:23, Kyungmin Park schreef: >> Hi, >> >> I agree your approach, put the common features in common place. >> but Samsung maintainers insist put these at each machine file at current time. >> >> So move this to the each machines for their tastes. > I did it that way first, but then wondered why this wasn't done for all boards. > > When looking at some S3C24XX boards, you'll see that these need changes to the > bootloader to support suspend; but IIRC this isn't needed for S3C64XX so I think > this can be safely enabled for all S3C64XX boards? There are be answered by Samsung maintainers. I'm have same opinions since it's common feature. Previous time I already argued with them but they reject it. you can issue it again. and current status. # grep s3c_pm_init -H -R arch/arm/mach-* arch/arm/mach-s3c2410/mach-qt2410.c: s3c_pm_init(); arch/arm/mach-s3c2410/mach-h1940.c: s3c_pm_init(); arch/arm/mach-s3c2412/mach-jive.c: s3c_pm_init(); arch/arm/mach-s3c2440/mach-rx3715.c: s3c_pm_init(); arch/arm/mach-s3c2440/mach-gta02.c: s3c_pm_init(); arch/arm/mach-s3c2440/mach-rx1950.c: s3c_pm_init(); arch/arm/mach-s5pv210/mach-smdkv210.c: s3c_pm_init(); arch/arm/mach-s5pv210/mach-smdkc110.c: s3c_pm_init(); Thank you, Kyungmin Park > > -- > Maurus Cuelenaere > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-05 23:23 ` Kyungmin Park 2010-10-05 23:27 ` Maurus Cuelenaere @ 2010-10-06 22:22 ` Ben Dooks 2010-10-06 22:27 ` Maurus Cuelenaere 1 sibling, 1 reply; 8+ messages in thread From: Ben Dooks @ 2010-10-06 22:22 UTC (permalink / raw) To: linux-arm-kernel On 06/10/10 00:23, Kyungmin Park wrote: > Hi, > > I agree your approach, put the common features in common place. > but Samsung maintainers insist put these at each machine file at current time. This is just an init call, the actuall implementation is common to the core. We did it this was as it was not clear if _all_ machines under the architecture could do this by default, or would need extra code in their mach implementation, or in a driver elsewhere. I would still prefer each machine that can do pm to call s3c_pm_init() in their setup code to ensure that we don't enable pm on a machine with possibly incomplete support (especially as PM can be one of the more difficult things to debug). ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: S3C64XX: Add suspend support 2010-10-06 22:22 ` Ben Dooks @ 2010-10-06 22:27 ` Maurus Cuelenaere 0 siblings, 0 replies; 8+ messages in thread From: Maurus Cuelenaere @ 2010-10-06 22:27 UTC (permalink / raw) To: linux-arm-kernel Op 07-10-10 00:22, Ben Dooks schreef: > I would still prefer each machine that can do pm to call s3c_pm_init() > in their setup code to ensure that we don't enable pm on a machine with > possibly incomplete support (especially as PM can be one of the more > difficult things to debug). Ok, will resend this with the call only added to mach-smartq.c -- Maurus Cuelenaere ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards 2010-10-05 23:09 [PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support Maurus Cuelenaere 2010-10-05 23:09 ` [PATCH 1/2] ARM: S3C64XX: Add " Maurus Cuelenaere @ 2010-10-05 23:10 ` Maurus Cuelenaere 1 sibling, 0 replies; 8+ messages in thread From: Maurus Cuelenaere @ 2010-10-05 23:10 UTC (permalink / raw) To: linux-arm-kernel This patch adds the power on/off button on both SmartQ boards as suspend wakeup sources. Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail•com> --- arch/arm/mach-s3c64xx/mach-smartq5.c | 1 + arch/arm/mach-s3c64xx/mach-smartq7.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-smartq5.c b/arch/arm/mach-s3c64xx/mach-smartq5.c index a4d59b0..57b84d3 100644 --- a/arch/arm/mach-s3c64xx/mach-smartq5.c +++ b/arch/arm/mach-s3c64xx/mach-smartq5.c @@ -64,6 +64,7 @@ static struct gpio_keys_button smartq5_buttons[] = { .desc = "Power", .active_low = 1, .debounce_interval = 5, + .wakeup = 1, .type = EV_KEY, }, { diff --git a/arch/arm/mach-s3c64xx/mach-smartq7.c b/arch/arm/mach-s3c64xx/mach-smartq7.c index e50a7d7..5b2f9fe 100644 --- a/arch/arm/mach-s3c64xx/mach-smartq7.c +++ b/arch/arm/mach-s3c64xx/mach-smartq7.c @@ -64,6 +64,7 @@ static struct gpio_keys_button smartq7_buttons[] = { .desc = "Power", .active_low = 1, .debounce_interval = 5, + .wakeup = 1, .type = EV_KEY, }, { -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-06 22:27 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-10-05 23:09 [PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support Maurus Cuelenaere 2010-10-05 23:09 ` [PATCH 1/2] ARM: S3C64XX: Add " Maurus Cuelenaere 2010-10-05 23:23 ` Kyungmin Park 2010-10-05 23:27 ` Maurus Cuelenaere 2010-10-05 23:39 ` Kyungmin Park 2010-10-06 22:22 ` Ben Dooks 2010-10-06 22:27 ` Maurus Cuelenaere 2010-10-05 23:10 ` [PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards Maurus Cuelenaere
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox