* [PATCH] at91: fix compile breakage with VMALLOC_END
@ 2011-11-08 10:28 Jamie Iles
2011-11-08 10:54 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Jamie Iles @ 2011-11-08 10:28 UTC (permalink / raw)
To: linux-arm-kernel
From: Jamie Iles <jamie@jamieiles•com>
VMALLOC_END is defined in terms of AT91_VIRT_BASE but this needs
mach/hardware.h for it's definition.
In file included from arch/arm/mach-at91/board-usb-a926x.c:26:0:
include/linux/mm.h: In function 'is_vmalloc_addr':
include/linux/mm.h:305:41: error: 'AT91_VIRT_BASE' undeclared (first use in this function)
include/linux/mm.h:305:41: note: each undeclared identifier is reported only once for each function it appears in
Cc: Nicolas Ferre <nicolas.ferre@atmel•com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft•com>
Signed-off-by: Jamie Iles <jamie@jamieiles•com>
---
This is a bit more heavyweight than most of the other platforms,
but it's the simplest fix.
arch/arm/mach-at91/include/mach/vmalloc.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-at91/include/mach/vmalloc.h b/arch/arm/mach-at91/include/mach/vmalloc.h
index 8eb459f..8e4a1bd 100644
--- a/arch/arm/mach-at91/include/mach/vmalloc.h
+++ b/arch/arm/mach-at91/include/mach/vmalloc.h
@@ -21,6 +21,8 @@
#ifndef __ASM_ARCH_VMALLOC_H
#define __ASM_ARCH_VMALLOC_H
+#include <mach/hardware.h>
+
#define VMALLOC_END (AT91_VIRT_BASE & PGDIR_MASK)
#endif
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] at91: fix compile breakage with VMALLOC_END
2011-11-08 10:28 [PATCH] at91: fix compile breakage with VMALLOC_END Jamie Iles
@ 2011-11-08 10:54 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2011-11-08 10:54 UTC (permalink / raw)
To: linux-arm-kernel
On 11/08/2011 11:28 AM, Jamie Iles :
> From: Jamie Iles <jamie@jamieiles•com>
>
> VMALLOC_END is defined in terms of AT91_VIRT_BASE but this needs
> mach/hardware.h for it's definition.
>
> In file included from arch/arm/mach-at91/board-usb-a926x.c:26:0:
> include/linux/mm.h: In function 'is_vmalloc_addr':
> include/linux/mm.h:305:41: error: 'AT91_VIRT_BASE' undeclared (first use in this function)
> include/linux/mm.h:305:41: note: each undeclared identifier is reported only once for each function it appears in
>
> Cc: Nicolas Ferre <nicolas.ferre@atmel•com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft•com>
> Signed-off-by: Jamie Iles <jamie@jamieiles•com>
Jean-Christophe already posted the very same patch for this. But maybe
he can take your description...
Best regards,
> ---
>
> This is a bit more heavyweight than most of the other platforms,
> but it's the simplest fix.
>
> arch/arm/mach-at91/include/mach/vmalloc.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-at91/include/mach/vmalloc.h b/arch/arm/mach-at91/include/mach/vmalloc.h
> index 8eb459f..8e4a1bd 100644
> --- a/arch/arm/mach-at91/include/mach/vmalloc.h
> +++ b/arch/arm/mach-at91/include/mach/vmalloc.h
> @@ -21,6 +21,8 @@
> #ifndef __ASM_ARCH_VMALLOC_H
> #define __ASM_ARCH_VMALLOC_H
>
> +#include <mach/hardware.h>
> +
> #define VMALLOC_END (AT91_VIRT_BASE & PGDIR_MASK)
>
> #endif
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-08 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08 10:28 [PATCH] at91: fix compile breakage with VMALLOC_END Jamie Iles
2011-11-08 10:54 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox