From: shubhrajyoti@ti•com (Shubhrajyoti)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv8 3/5] OMAP: I2C: Reset support
Date: Fri, 16 Dec 2011 14:27:30 +0530 [thread overview]
Message-ID: <4EEB07FA.1020100@ti.com> (raw)
In-Reply-To: <4EEB068C.3010501@ti.com>
Hi Benoit,
On Friday 16 December 2011 02:21 PM, Cousson, Benoit wrote:
> Hi Shubhro,
>
> On 12/13/2011 11:55 AM, Shubhrajyoti D wrote:
>> Under some error conditions the i2c driver may do a reset.
>> Adding a reset field and support in the device-specific code to aid
>> error-recovery.
>>
>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti•com>
>> ---
>> arch/arm/plat-omap/i2c.c | 2 ++
>> include/linux/i2c-omap.h | 1 +
>> 2 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/i2c.c b/arch/arm/plat-omap/i2c.c
>> index db071bc..6cddde2 100644
>> --- a/arch/arm/plat-omap/i2c.c
>> +++ b/arch/arm/plat-omap/i2c.c
>> @@ -179,6 +179,8 @@ static inline int omap2_i2c_add_bus(int bus_id)
>> */
>> if (cpu_is_omap34xx())
>> pdata->set_mpu_wkup_lat =
>> omap_pm_set_max_mpu_wakeup_lat_compat;
>> +
>> + pdata->device_reset = omap_device_reset;
>
> We should avoid introducing any new pdata function pointers since we
> are in the process of removing them for DT support.
However if the driver has to do a reset due to some error what is the
recommended way?
Currently we used to access the SYSC directly I am removing the same and
introducing this function pointer.
>
> Regards,
> Benoit
next prev parent reply other threads:[~2011-12-16 8:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 10:55 [PATCHv8 0/5] I2C driver updates Shubhrajyoti D
2011-12-13 10:55 ` [PATCHv8 1/5] OMAP3+: HWMOD: Add the default clockactivity for I2C Shubhrajyoti D
2011-12-16 8:35 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 2/5] OMAP: hwmod/device : add omap_device_reset to reset all the hwmods in the device Shubhrajyoti D
2011-12-16 8:42 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 3/5] OMAP: I2C: Reset support Shubhrajyoti D
2011-12-16 8:38 ` Paul Walmsley
2011-12-16 8:51 ` Cousson, Benoit
2011-12-16 8:57 ` Shubhrajyoti [this message]
2011-12-16 17:26 ` Tony Lindgren
2011-12-13 10:55 ` [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path Shubhrajyoti D
2011-12-16 8:40 ` Paul Walmsley
2011-12-16 8:59 ` Shubhrajyoti
[not found] ` <CANQgH-Ze1S6sy1uhzy_b8GWOCjF4+-9DOCcUn9mq1kAaT+Y7FA@mail.gmail.com>
2012-01-10 6:24 ` Datta, Shubhrajyoti
2012-01-10 15:26 ` Kevin Hilman
2012-01-11 6:06 ` Shubhrajyoti
2012-01-11 13:29 ` Paul Walmsley
2012-01-11 13:58 ` Shubhrajyoti
2012-01-11 15:07 ` Paul Walmsley
2012-01-11 14:23 ` Cousson, Benoit
2012-01-11 15:22 ` Paul Walmsley
2012-01-12 14:13 ` Cousson, Benoit
2012-01-12 23:22 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 5/5] OMAP: I2C: Remove the SYSC register definition Shubhrajyoti D
2011-12-16 8:41 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB07FA.1020100@ti.com \
--to=shubhrajyoti@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox