From: shubhrajyoti@ti•com (Shubhrajyoti)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path
Date: Wed, 11 Jan 2012 11:36:23 +0530 [thread overview]
Message-ID: <4F0D26DF.1020108@ti.com> (raw)
In-Reply-To: <87hb03tw8h.fsf@ti.com>
On Tuesday 10 January 2012 08:56 PM, Kevin Hilman wrote:
> "Datta, Shubhrajyoti" <shubhrajyoti@ti•com> writes:
>
>> On Tue, Jan 10, 2012 at 11:53 AM, Datta, Shubhrajyoti
>> <shubhrajyoti@ti•com> wrote:
>>>
>>>
>>> On Fri, Dec 16, 2011 at 2:29 PM, Shubhrajyoti <shubhrajyoti@ti•com> wrote:
>>>> Ben,
>>>>
>>>> On Friday 16 December 2011 02:10 PM, Paul Walmsley wrote:
>>>>> Hi
>>>>>
>>>>> On Tue, 13 Dec 2011, Shubhrajyoti D wrote:
>>>>>
>>>>>> - The reset in the driver at init is not needed anymore as the
>>>>>> hwmod framework takes care of reseting it.
>>>>>> - Reset is removed from omap_i2c_init, which was called
>>>>>> not only during probe, but also after time out and error handling.
>>>>>> device_reset were added in those places to effect the reset.
>>>>>> - Earlier the hwmod SYSC settings were over-written in the driver.
>>>>>> Removing the same and letting the hwmod take care of the settings.
>>>>>> - Clean up the SYSS_RESETDONE_MASK macro as it is no longer needed.
>>>>>> - Clean up the SYSCONFIG SYSC bit definition macros.
>>>>>> - Fix the typos in wakeup.
>>>>>>
>>>>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti•com>
>>>>>> ---
>>>>>> drivers/i2c/busses/i2c-omap.c | 83 +++++++++++-----------------------------
>>>>>> 1 files changed, 23 insertions(+), 60 deletions(-)
>>>>> This patch either needs to be acked by Ben with a note that it's okay for
>>>>> us to merge through the OMAP tree, or needs to be merged by Ben during the
>>>>> 3.4 merge window, after patches 1-3 have reached the mainline tree.
>>>> I agree.
>>>> Ben do you have any comments .
>>>
>> If there are no further comments can this be merged also ?
> As Benoit mentioned earlier, the addition of new pdata fields will cause
> problems with the DT support already queued for v3.3.
>
> This series should be reworked on top of the DT support which Ben has
> now queued for v3.3 (my branch: for_3.3/i2c/misc)
Yes will rework it.
> Kevin
next prev parent reply other threads:[~2012-01-11 6:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 10:55 [PATCHv8 0/5] I2C driver updates Shubhrajyoti D
2011-12-13 10:55 ` [PATCHv8 1/5] OMAP3+: HWMOD: Add the default clockactivity for I2C Shubhrajyoti D
2011-12-16 8:35 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 2/5] OMAP: hwmod/device : add omap_device_reset to reset all the hwmods in the device Shubhrajyoti D
2011-12-16 8:42 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 3/5] OMAP: I2C: Reset support Shubhrajyoti D
2011-12-16 8:38 ` Paul Walmsley
2011-12-16 8:51 ` Cousson, Benoit
2011-12-16 8:57 ` Shubhrajyoti
2011-12-16 17:26 ` Tony Lindgren
2011-12-13 10:55 ` [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path Shubhrajyoti D
2011-12-16 8:40 ` Paul Walmsley
2011-12-16 8:59 ` Shubhrajyoti
[not found] ` <CANQgH-Ze1S6sy1uhzy_b8GWOCjF4+-9DOCcUn9mq1kAaT+Y7FA@mail.gmail.com>
2012-01-10 6:24 ` Datta, Shubhrajyoti
2012-01-10 15:26 ` Kevin Hilman
2012-01-11 6:06 ` Shubhrajyoti [this message]
2012-01-11 13:29 ` Paul Walmsley
2012-01-11 13:58 ` Shubhrajyoti
2012-01-11 15:07 ` Paul Walmsley
2012-01-11 14:23 ` Cousson, Benoit
2012-01-11 15:22 ` Paul Walmsley
2012-01-12 14:13 ` Cousson, Benoit
2012-01-12 23:22 ` Paul Walmsley
2011-12-13 10:55 ` [PATCHv8 5/5] OMAP: I2C: Remove the SYSC register definition Shubhrajyoti D
2011-12-16 8:41 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D26DF.1020108@ti.com \
--to=shubhrajyoti@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox