* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
[not found] <4F1E7F8A.4010805@ti.com>
@ 2012-01-25 1:35 ` Ameya Palande
2012-01-25 19:04 ` Paul Walmsley
2012-01-25 19:05 ` Paul Walmsley
0 siblings, 2 replies; 4+ messages in thread
From: Ameya Palande @ 2012-01-25 1:35 UTC (permalink / raw)
To: linux-arm-kernel
According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
following fields for multiplication and division factors:
DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
Acked-by: Benoit Cousson <b-cousson@ti•com>
Signed-off-by: Ameya Palande <ameya.palande@ti•com>
---
arch/arm/mach-omap2/clock44xx_data.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
index 08e86d7..053cc15 100644
--- a/arch/arm/mach-omap2/clock44xx_data.c
+++ b/arch/arm/mach-omap2/clock44xx_data.c
@@ -953,8 +953,8 @@ static struct dpll_data dpll_usb_dd = {
.modes = (1 << DPLL_LOW_POWER_BYPASS) | (1 << DPLL_LOCKED),
.autoidle_reg = OMAP4430_CM_AUTOIDLE_DPLL_USB,
.idlest_reg = OMAP4430_CM_IDLEST_DPLL_USB,
- .mult_mask = OMAP4430_DPLL_MULT_MASK,
- .div1_mask = OMAP4430_DPLL_DIV_MASK,
+ .mult_mask = OMAP4430_DPLL_MULT_USB_MASK,
+ .div1_mask = OMAP4430_DPLL_DIV_0_7_MASK,
.enable_mask = OMAP4430_DPLL_EN_MASK,
.autoidle_mask = OMAP4430_AUTO_DPLL_MODE_MASK,
.idlest_mask = OMAP4430_ST_DPLL_CLK_MASK,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
2012-01-25 1:35 ` [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande
@ 2012-01-25 19:04 ` Paul Walmsley
2012-01-25 19:05 ` Paul Walmsley
1 sibling, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2012-01-25 19:04 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 24 Jan 2012, Ameya Palande wrote:
> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
> following fields for multiplication and division factors:
>
> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
>
> Acked-by: Benoit Cousson <b-cousson@ti•com>
> Signed-off-by: Ameya Palande <ameya.palande@ti•com>
Thanks, queued for 3.4.
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
2012-01-25 1:35 ` [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande
2012-01-25 19:04 ` Paul Walmsley
@ 2012-01-25 19:05 ` Paul Walmsley
2012-01-25 19:46 ` Cousson, Benoit
1 sibling, 1 reply; 4+ messages in thread
From: Paul Walmsley @ 2012-01-25 19:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi
one important question first:
On Tue, 24 Jan 2012, Ameya Palande wrote:
> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
> following fields for multiplication and division factors:
>
> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
>
> Acked-by: Benoit Cousson <b-cousson@ti•com>
> Signed-off-by: Ameya Palande <ameya.palande@ti•com>
Have the scripts been updated?
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL
2012-01-25 19:05 ` Paul Walmsley
@ 2012-01-25 19:46 ` Cousson, Benoit
0 siblings, 0 replies; 4+ messages in thread
From: Cousson, Benoit @ 2012-01-25 19:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Paul,
On 1/25/2012 8:05 PM, Paul Walmsley wrote:
> Hi
>
> one important question first:
>
> On Tue, 24 Jan 2012, Ameya Palande wrote:
>
>> According to OMAP4 TRM Table 3-1183, CM_CLKSEL_DPLL_USB register defines
>> following fields for multiplication and division factors:
>>
>> DPLL_MULT (bits 19:8) DPLL multiplier factor (2 to 4095)
>> DPLL_DIV (bits 7:0) DPLL divider factor (0 to 255)
>>
>> Acked-by: Benoit Cousson<b-cousson@ti•com>
>> Signed-off-by: Ameya Palande<ameya.palande@ti•com>
>
> Have the scripts been updated?
No not yet. The easy fix I was thinking about is to replace this define
by the hexa value of the mask. I can extract directly from the max mult
and max div.
Regards,
Benoit
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-25 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4F1E7F8A.4010805@ti.com>
2012-01-25 1:35 ` [PATCH] ARM: OMAP4: clock: fix mult and div mask for USB_DPLL Ameya Palande
2012-01-25 19:04 ` Paul Walmsley
2012-01-25 19:05 ` Paul Walmsley
2012-01-25 19:46 ` Cousson, Benoit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox