From: sshtylyov@ru•mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP
Date: Tue, 31 Jan 2012 15:37:08 +0400 [thread overview]
Message-ID: <4F27D264.9050203@ru.mvista.com> (raw)
In-Reply-To: <CAORVsuUNM8bpwyjbG2GcwfiUEf7A54ODC4tfhZNinUhQTE3g5w@mail.gmail.com>
Hello.
On 31-01-2012 14:06, Jean Pihet wrote:
> ...
>>> +int sr_disable_errgen(struct voltagedomain *voltdm)
>>> +{
>>> + u32 errconfig_offs, vpboundint_en;
>>> + u32 vpboundint_st;
>>> + struct omap_sr *sr = _sr_lookup(voltdm);
>>> +
>>> + if (IS_ERR(sr)) {
>>> + pr_warning("%s: omap_sr struct for sr_%s not found\n",
>>> + __func__, voltdm->name);
>>> + return -EINVAL;
>>
>>
>> Not PTR_ERR(sr)?
> _sr_lookup returns a return code using ERR_PTR so the return value
> should be checked for errors using IS_ERR. Please note that _sr_lookup
> checks for NULL parameter internally.
That's clear. I was asking don't you want to return PTR_ERR(sr) instead of
-EINVAL.
WBR, Sergei
next prev parent reply other threads:[~2012-01-31 11:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 15:16 [PATCH 00/21] OMAP3+: SR: bugfixes Jean Pihet
2012-01-25 15:16 ` [PATCH 01/21] OMAP3+: SR Layer Cleanup [V4] Jean Pihet
2012-01-25 15:16 ` [PATCH 02/21] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code Jean Pihet
2012-01-25 15:16 ` [PATCH 03/21] OMAP3+: PM: SR: add suspend/resume handlers Jean Pihet
2012-01-25 15:16 ` [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq Jean Pihet
2012-01-25 18:29 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 05/21] Revert "OMAP3+: PM: SR: add suspend/resume handlers" Jean Pihet
2012-01-25 17:53 ` Cousson, Benoit
2012-01-25 18:13 ` Jean Pihet
2012-01-25 18:25 ` Cousson, Benoit
2012-01-25 18:49 ` Kevin Hilman
2012-01-25 21:29 ` Menon, Nishanth
2012-01-26 7:31 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 06/21] OMAP3+: Smartreflex: fix err interrupt disable sequence Jean Pihet
2012-01-25 15:16 ` [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP Jean Pihet
2012-01-26 11:26 ` Sergei Shtylyov
2012-01-31 10:06 ` Jean Pihet
2012-01-31 11:37 ` Sergei Shtylyov [this message]
2012-01-31 13:39 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 08/21] OMAP3+: Smartreflex: Add a shutdown hook Jean Pihet
2012-01-26 11:21 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 09/21] OMAP3+: Smartreflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-01-26 11:28 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 10/21] OMAP3+: Smartreflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-01-26 11:29 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 11/21] OMAP3: hwmod: add SmartReflex IRQs Jean Pihet
2012-01-26 11:30 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 12/21] OMAP3+: SR: introduce class init,deinit and priv data Jean Pihet
2012-01-26 11:31 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 13/21] OMAP3+: SR: introduce notifiers flags Jean Pihet
2012-01-25 15:16 ` [PATCH 14/21] OMAP3+: SR: introduce notifier_control Jean Pihet
2012-01-25 15:16 ` [PATCH 15/21] OMAP3+: SR: disable spamming interrupts Jean Pihet
2012-01-25 15:16 ` [PATCH 16/21] OMAP3+: SR: introduce class private data per voltage domain Jean Pihet
2012-01-25 15:16 ` [PATCH 17/21] OMAP3430: SR: class3: restrict CPU to run on Jean Pihet
2012-01-26 11:33 ` Sergei Shtylyov
2012-01-26 12:22 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 18/21] arm: omap: smartreflex: add missing platform_set_drvdata() Jean Pihet
2012-01-25 15:16 ` [PATCH 19/21] arm: omap: smartreflex: move late_initcall() closer to its argument Jean Pihet
2012-01-25 15:16 ` [PATCH 20/21] arm: omap: smartreflex: clean ups all over Jean Pihet
2012-01-25 15:16 ` [PATCH 21/21] arm: omap: smartreflex: micro-optimization for sanity check Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F27D264.9050203@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox