From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ
Date: Fri, 24 Feb 2012 11:11:10 +0100 [thread overview]
Message-ID: <4F47623E.5060908@ti.com> (raw)
In-Reply-To: <20120223230821.GD18185@atomide.com>
+ Tarun
On 2/24/2012 12:08 AM, Tony Lindgren wrote:
> * Cousson, Benoit<b-cousson@ti•com> [120223 14:14]:
>> The GPIO driver is still relying on internal OMAP IRQ defines that
>> are not relevant anymore if OMAP is built with SPARSE_IRQ.
>
> Great :)
>
>> Please note that this patch is still RFC, because I do not know
>> how to fix properly the ugly cpu_class_is_omap1 and the dependency
>> with IH_MPUIO_BASE to detect a MPUIO.
>
> Sounds like gpio_to_irq() needs to be set in the
> arch/arm/*omap*/gpio*.c then.
In fact, after a second thought, that might even work for OMAP1 because
I'm using the proper base (IRQ and GPIO) to convert the IRQ number.
static int irq_to_gpio(struct gpio_bank *bank, unsigned int gpio_irq)
{
return gpio_irq - bank->irq_base + bank->chip.base;
}
But it might be good to test it on OMAP1 platform.
Tarun,
Do you have an OMAP1 board to test that.
Regards,
Benoit
next prev parent reply other threads:[~2012-02-24 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:46 [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ Cousson, Benoit
2012-02-23 23:08 ` Tony Lindgren
2012-02-24 10:11 ` Cousson, Benoit [this message]
2012-02-24 10:37 ` DebBarma, Tarun Kanti
2012-02-24 13:24 ` DebBarma, Tarun Kanti
2012-02-24 13:32 ` Cousson, Benoit
2012-02-24 13:53 ` DebBarma, Tarun Kanti
2012-02-24 13:56 ` Cousson, Benoit
2012-02-24 15:09 ` DebBarma, Tarun Kanti
2012-02-24 15:12 ` Cousson, Benoit
2012-02-24 14:14 ` Rob Herring
2012-02-24 14:54 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47623E.5060908@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox